Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/tsconfig file configurable #132

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pr/tsconfig file configurable #132

wants to merge 2 commits into from

Conversation

Knaackee
Copy link

For my project i need to use a different tsconfig.json for development and deployment.
In order to do that, I extended serverless-plugin-typescript and added the ability to configure a path to a tsconfig.json. I already use this in production.

I also added tests and documentation (README.md).

Allows to configure the path to the tsconfig.json file
@JackCuthbert
Copy link
Contributor

JackCuthbert commented Jul 12, 2019

Hi @Knaackee thanks for submitting this one! Do you feel that adding the custom.typeScript:tsconfigFilePath configuration is the best way to implement this functionality?

Perhaps we can make an assumption that if the developer has a tsconfig.json file in their directory we should use that instead of the built-in config? (with some validation and documentation of course)

Edit: Sorry, I misunderstood, it appears that the plugin does use a tsconfig.json in the root directory if it exists (ref). I think this would be a good thing to support, using different dev/prod tsconfigs is certainly a thing people do :) Would you be able to rebase your branch on master now there has been a few changes?

@KingDarBoja
Copy link

Any update on this? Looks like the author went MIA (missing in action) as there hasn't been a rebase with latest changes on master.

Maybe another PR which mirror the changes could do the job, just saying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants