Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply @/theoparis' fixes for arm simd #575

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itsjunetime
Copy link

This fixes #571 by applying the changes found in https://github.com/theoparis/pathfinder. I'm not certain why @theoparis did not upstream these themself, but I would like this fix upstreamed, so I'm filing this.

I haven't tested this with versions of nightly before the rust commit that broke this code, so it might break those, but I expect there are more people are using the most recent version of nightly than people using versions that still work with pathfinder_simd.

@theoparis
Copy link

theoparis commented Feb 13, 2025

I didn't upstream this because I didn't realize these changes would work on stable rust with repr_simd feature-gated - I thought it required nightly rust. Thanks for creating this PR.

@itsjunetime
Copy link
Author

It does require nightly, but it seems that pathfinder has their own pf_rustc_nightly cfg to enable compilation that is conditional upon running it under nightly. I didn't realize that at first either, it took me a second of poking to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile error on nightly: invalid monomorphization, simd_shuffle index must be a SIMD vector
2 participants