Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harfbuzz to 8.3.1 fix clang-cl build #248

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Nopey
Copy link
Contributor

@Nopey Nopey commented Feb 13, 2024

See harfbuzz/harfbuzz#4585, which fixes the build of this in servo on Windows.

@waywardmonkeys
Copy link
Collaborator

We've been updating to actual releases, not (semi-)random points in time ... might be worth checking to see when he next plans a release.

Also, probably worth submitting a PR to harfbuzz to do CI builds with clang-cl to avoid this happening again in the future.

@jschwe
Copy link
Member

jschwe commented Mar 17, 2024

@Nopey FYI harfbuzz 8.3.1 was just released

This fixes the clang-cl build.
@Nopey
Copy link
Contributor Author

Nopey commented Mar 18, 2024

Thanks jschwe! Updated this MR to use latest upstream release 8.3.1, which includes the commit b8178f25 that fixes clang-cl builds.

Also, probably worth submitting a PR to harfbuzz to do CI builds with clang-cl to avoid this happening again in the future.

I looked into this on my ci-clang-cl branch; I'm running into issues when harfbuzz's meson scripts try to build freetype. I'll have to look into adding clang-cl to freetype's gitlab ci, but haven't started that work.

@Nopey Nopey changed the title Update harfbuzz to fix clang-cl build Update harfbuzz to 8.3.1 fix clang-cl build Mar 18, 2024
@mrobinson mrobinson added this pull request to the merge queue Mar 18, 2024
Merged via the queue into servo:main with commit 2ce0a6d Mar 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants