Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DrainFilter with ExtractIf #341

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

NaokiM03
Copy link
Contributor

@NaokiM03 NaokiM03 commented Mar 5, 2024

Renamed the same as std and modified the implementation details.

Links:
rust-lang/rust#104455
rust-lang/rust#112677
rust-lang/libs-team#136
rust-lang/rust#43244

Copy link
Collaborator

@mbrubeck mbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mbrubeck mbrubeck added this pull request to the merge queue Mar 5, 2024
Merged via the queue into servo:v2 with commit 5522939 Mar 5, 2024
6 checks passed
@NaokiM03
Copy link
Contributor Author

NaokiM03 commented Mar 5, 2024

@mbrubeck
Is it necessary to port to v1?

@NaokiM03 NaokiM03 deleted the v2_replace_drain_filter_with_extract_if branch March 5, 2024 20:07
@mbrubeck
Copy link
Collaborator

mbrubeck commented Mar 5, 2024

Is it necessary to port to v1?

No, I would prefer to minimize changes to v1. I hope to make a stable release of v2 within a few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants