Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace write feature with std feature #356

Merged
merged 2 commits into from
May 14, 2024
Merged

feat: replace write feature with std feature #356

merged 2 commits into from
May 14, 2024

Conversation

JarvisCraft
Copy link
Contributor

@JarvisCraft JarvisCraft commented May 13, 2024 •
edited
Loading

Description

This adds a new std feature to enable std-specific trait implementations.
This also implements std::error::Error on CollectionAllocErr.

This resolves #355

@JarvisCraft
feat: replace write feature with std feature
7e8d001 
This also implements `std::error::Error` on `CollectionAllocErr`
@JarvisCraft
docs: describe std feature
47c5fa9
mbrubeck
mbrubeck approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@mbrubeck mbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mbrubeck mbrubeck added this pull request to the merge queue May 14, 2024
Merged via the queue into servo:v2 with commit 1dd57a4 May 14, 2024
5 checks passed
@JarvisCraft JarvisCraft deleted the std-feature branch May 14, 2024 20:57
@nicoburns nicoburns mentioned this pull request Oct 22, 2024
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrubeck mbrubeck mbrubeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement std::error::Error for CollectionAllocErr
2 participants
@JarvisCraft @mbrubeck