Remove dependency on webrender_api
#92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nico Burns <[email protected]>
3 tasks
Loirooriol
approved these changes
Nov 25, 2024
|
This has been accepted (but not yet landed) upstream. But I'm going to land it here to so we can get the Servo PR merged (and make sure it doesn't regress before we next sync Stylo). |
This was referenced Dec 4, 2024
|
When you open a PR, can you use a branch from your fork? Or at least delete it afterwards. It's weird if the repo accumulates branches from past PRs. |
|
Sure! We could also turn on the option to automatically delete branches of merged PRs. |
|
Ah, makes sense. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have submitted this upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1933010
We can actually land the Servo PR without landing this first. But we might want to land anyway this to ensure that Servo doesn't regress before the next stylo sync.
Servo PR: servo/servo#34353