Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding Warning modals #5

Merged
merged 9 commits into from
Nov 18, 2024
Merged

Onboarding Warning modals #5

merged 9 commits into from
Nov 18, 2024

Conversation

Miki-Session
Copy link
Collaborator

  • Two new test specs for pressing back and triggering the Warning modal during the Onboarding flows
  • checkModal function logic change
    • error case first
    • console log for correct case

@Miki-Session
Copy link
Collaborator Author

Note: it looks like the latest from oxen-io/main still needs to be merged into session-foundation/main

burtonemily
burtonemily approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@burtonemily burtonemily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@burtonemily burtonemily merged commit 832635d into session-foundation:main Nov 18, 2024
1 check passed
@Miki-Session Miki-Session deleted the onboarding-modals branch November 18, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burtonemily burtonemily burtonemily approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Miki-Session @burtonemily