Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build locale types fully #3

Merged
merged 8 commits into from
Jan 8, 2025
Merged

fix: build locale types fully #3

merged 8 commits into from
Jan 8, 2025

Conversation

Bilb
Copy link
Collaborator

@Bilb Bilb commented Nov 13, 2024

No description provided.

@Bilb Bilb mentioned this pull request Nov 13, 2024
Closed
@Bilb Bilb force-pushed the fix-build-locale-types-fully branch from 5128c4a to da39198 Compare January 3, 2025 01:02
@Bilb Bilb requested a review from yougotwill January 3, 2025 05:56
@Bilb Bilb marked this pull request as ready for review January 3, 2025 05:57
@Bilb Bilb changed the base branch from unstable to release/1.15.0 January 3, 2025 05:57
@Bilb Bilb force-pushed the fix-build-locale-types-fully branch 8 times, most recently from 09e66ae to 6d3135b Compare January 5, 2025 23:33
@Bilb Bilb force-pushed the fix-build-locale-types-fully branch from 6d3135b to 97e95ef Compare January 5, 2025 23:37
yougotwill
yougotwill requested changes Jan 6, 2025
View reviewed changes
.eslintrc.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
ts/components/conversation/message/message-item/GroupUpdateMessage.tsx Outdated Show resolved Hide resolved
ts/components/conversation/message/message-item/notification-bubble/CallNotification.tsx Show resolved Hide resolved
ts/components/conversation/message/reactions/ReactionPopup.tsx Outdated Show resolved Hide resolved
ts/localization/localeTools.ts Outdated Show resolved Hide resolved
ts/localization/localeTools.ts Show resolved Hide resolved
ts/models/groupUpdate.ts Show resolved Hide resolved
ts/test/session/unit/utils/i18n/getRawMessage_test.ts Show resolved Hide resolved
ts/util/i18n/functions/getMessage.ts Outdated Show resolved Hide resolved
yougotwill
yougotwill requested changes Jan 6, 2025
View reviewed changes
ts/state/ducks/metaGroups.ts Outdated Show resolved Hide resolved
@Bilb Bilb force-pushed the fix-build-locale-types-fully branch from fcc4f38 to a44dc50 Compare January 6, 2025 04:45
yougotwill
yougotwill approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@yougotwill yougotwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@Bilb Bilb merged commit 0513171 into session-foundation:release/1.15.0 Jan 8, 2025
6 checks passed
@Bilb Bilb deleted the fix-build-locale-types-fully branch January 8, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yougotwill yougotwill yougotwill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bilb @yougotwill