On Windows, do not degenerate working directory through restarts #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMulthaupt
force-pushed
the
bug-231-appdata-network-path
branch
2 times, most recently
from
c6c498c
to
34760af
Compare
…ing command execution failure when APPDATA is a drive name-based path which maps to a UNC share
MMulthaupt
force-pushed
the
bug-231-appdata-network-path
branch
from
34760af
to
1ce3d7a
Compare
dragetd
requested changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
WNetGetUniversalNameW()on Windows to see if lexically different paths may be semantically equivalent.Contains the usual ritual of wrapping WINAPI behavior with some sanitization. (I am looking at you,
ERROR_EXTENDED_ERRORandERROR_MORE_DATA)https://docs.microsoft.com/en-us/windows/win32/api/winnetwk/nf-winnetwk-wnetgetuniversalnamew
Fixes #231