Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hasher work with symlinks #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make hasher work with symlinks #83

wants to merge 2 commits into from

Conversation

dragetd
Copy link
Member

@dragetd dragetd commented Oct 29, 2019

No description provided.

@dragetd
Copy link
Member Author

dragetd commented Oct 29, 2019 •
edited
Loading

@ma-assbrock it needs to be rebased before it can be reviewed.

@dragetd
Copy link
Member Author

dragetd commented Sep 13, 2020

I would love if someone helps me writing a test here, because this is a little beyond my go-ngfu. =/

But since I am the only active maintainer, this PR will be also merged right away.

Marc-André Aßbrock and others added 2 commits April 14, 2021 15:42
@dragetd
Make hasher work with symlinks
fe5d815
@dragetd
Enable hashing symlinks
146ecad 
Example output:
```
INFO[0000] Hashing directory.                            hashesFile=x/bundleinfo.json pathToHash=x/ uniqueBundleName=x
INFO[0000] Hash "x/".
WARN[0000] File "x/foo"->"x/x2" is a symlink, will be treated as a regular file/dir.
INFO[0000] Finished hasher.
``

Symlinks with targets not within the hash directory are not allowed and cause a panic.
@dragetd dragetd marked this pull request as ready for review April 14, 2021 13:45
@dragetd dragetd changed the base branch from develop to master August 23, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MMulthaupt MMulthaupt Awaiting requested review from MMulthaupt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dragetd