Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Headline capitalization/canonicalization of node names. Main menu UX. #85

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

virtualritz
Copy link
Contributor

@virtualritz virtualritz commented Mar 15, 2023

  • Headline-capitalized all node names.
  • Made node naming more stringent: some nodes creating stuff have a Make prefix, but most do not. So I removed it everywhere.
    This needs more work but rules should be put down first; not least for other developers eventually writing nodes (e.g. use of verbs vs. nouns, use of plural vs. singular etc.)
  • Main menu:
    • Added (currently disabled) New and Quit entries.
    • Switched order of Save As…/Load (platform standards on Windows, macOS & all Linux desktops that have human interface guidelines).
    • Renamed Load to Open.
    • Swapped triple dots for real ellipsis and added to Open….
    • Renamed Help to Window.
    • Fixed spelling of Diagnostics.
    • Changed Diagnostics toggle button to checkbox.

@setzer22
Copy link
Owner

setzer22 commented Mar 15, 2023

Thanks for the PR! 😄

As I just mentioned in #86, there is the ongoing UI rewrite. But fortunately, most of the changes in your PR are in the node definitions and will work out of the box in the ui_next branch. I'll make sure to copy over the consistent capitalization for the remaining bits!

I'll merge once CI passes, I'm assuming there won't be any issues EDIT: Ooops, just as I wrote it rustfmt errored out. Make sure to run cargo fmt and push your branch 👍

@virtualritz
Copy link
Contributor Author

I did the rustfmt last week, in case that fell through the cracks.

@setzer22
Copy link
Owner

Ooops, sorry! Thanks for pointing that out :) Merging now!

@setzer22 setzer22 merged commit cecfc27 into setzer22:main Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants