Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model runner enhancement #37

Merged
merged 39 commits into from
Aug 7, 2024
Merged

Model runner enhancement #37

merged 39 commits into from
Aug 7, 2024

Conversation

mul14
Copy link
Contributor

@mul14 mul14 commented Jul 3, 2024

#21

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 80.45267% with 95 lines in your changes missing coverage. Please review.

Files Patch % Lines
pkg/db/aggregate.go 63.85% 21 Missing and 9 partials ⚠️
pkg/db/relation.go 64.58% 10 Missing and 7 partials ⚠️
pkg/db/utils.go 59.52% 15 Missing and 2 partials ⚠️
pkg/db/db.go 79.16% 9 Missing and 6 partials ⚠️
pkg/db/select.go 83.33% 6 Missing and 4 partials ⚠️
pkg/db/where.go 97.70% 3 Missing and 1 partial ⚠️
pkg/db/postgrest_request.go 60.00% 1 Missing and 1 partial ⚠️
Flag Coverage Δ
-race 71.91% <80.45%> (+0.54%) ⬆️
-tags "sonic avx" 71.90% <80.45%> (+0.44%) ⬆️
-tags go_json 71.83% <80.45%> (+0.35%) ⬆️
-tags nomsgpack 71.90% <80.45%> (+0.47%) ⬆️
go-1.21 71.19% <80.45%> (+0.60%) ⬆️
go-1.22 71.93% <80.45%> (+0.50%) ⬆️
macos-latest 71.95% <80.45%> (+0.47%) ⬆️
ubuntu-latest 71.92% <80.45%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/db/delete.go 77.77% <ø> (ø)
pkg/db/insert.go 66.66% <ø> (ø)
pkg/db/limit.go 100.00% <ø> (ø)
pkg/db/order.go 100.00% <ø> (ø)
pkg/db/update.go 77.77% <ø> (ø)
pkg/db/upsert.go 66.66% <ø> (ø)
pkg/generator/model.go 78.88% <ø> (ø)
pkg/resource/common.go 73.46% <100.00%> (ø)
pkg/db/postgrest_request.go 70.83% <60.00%> (ø)
pkg/db/where.go 97.70% <97.70%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

@toopay
Copy link
Member

toopay commented Jul 19, 2024

@mul14, can you rebase to the main branch? If this fulfills everything in #21, let's merge it.

@toopay
Copy link
Member

toopay commented Jul 24, 2024

  • Relation test
  • Docs

@toopay toopay merged commit 92b2426 into main Aug 7, 2024
25 checks passed
@toopay toopay deleted the model-runner branch August 7, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants