Switch to Rust edition 2018 #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Yeah, I think ctest needs to be replaced entirely with something that hooks directly into the compiler for info rather than trying to hackily parse it itself, but that's another project. Looks like you need to allow |
This was mostly automated using `cargo fix --edition`, except imports of openssl_sys (renamed to ffi) were converted to crate::ffi, which was reverted. The same thing is not done for the openssl-sys crate because this breaks ctest (used in systest to verify the -sys crate), see gnzlbg/ctest#70
This was mostly automated using `cargo fix --edition-idioms`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openssl-errors crate was already on the 2018 edition, and openssl-sys can't be updated without breaking the tests as ctest doesn't support modern Rust features.