Improving Code quality

.github/workflows/dotnet.yml

@@ -39,23 +39,18 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-
-      - name: Code Coverage Report
-        uses: codecov/codecov-action@v3
-        if: always()
-        with:
-          token: ${{ secrets.CODECOV }}
-          files: SimListenerTest/coverage.opencover.xml
-
+
       - name: Upload Results for Publishing
         uses: actions/upload-artifact@v3
+        if: always()
         with:
           name: Results
-          path: SimListenerTest/TestResults/*.trx
+          path: SimListenerTest/TestResults/*.trx , SimListenerTest/coverage.opencover.xml
 
   results:
     name: Results
     runs-on: ubuntu-latest
+    if: always()
     needs: [ test ]
     steps:
       - name: Download built project  
@@ -67,7 +62,14 @@ jobs:
         uses: EnricoMi/publish-unit-test-result-action@v2
         with:
            trx_files: "*.trx"
-
+
+      - name: Code Coverage Report
+        uses: codecov/codecov-action@v3
+        if: always()
+        with:
+          token: ${{ secrets.CODECOV }}
+          files: coverage.opencover.xml
+
   package:
     name: Package
     if: github.ref == 'refs/heads/main'

SimListener/Connect.cs

@@ -6,33 +6,11 @@
 
 namespace SimListener
 {
-    internal enum DEFINITION
-    {
-        Dummy = 0
-    };
-    internal enum REQUEST
-    {
-        Dummy = 0,
-        Struct1
-    };
-    internal enum EVENT
-    {
-        RECUR_1SEC,
-    }
-    internal enum REQUESTS
-    {
-        SIMULATION,
-        AIRCRAFT_LOADED,
-    }
     [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Ansi, Pack = 1)]
     internal struct ResultStructure
     {
-        // this is how you declare a fixed size string
         [MarshalAs(UnmanagedType.ByValTStr, SizeConst = 256)]
         public string sValue;
-
-        // other definitions can be added to this struct
-        // ...
     };
 
     public class Connect

SimListener/Enums.cs

@@ -0,0 +1,26 @@
+namespace SimListener
+{
+    public enum ErrorCodes
+    {
+        OK,
+        INVALID_DATA_REQUEST,
+    }
+    internal enum DEFINITION
+    {
+        Dummy = 0
+    };
+    internal enum REQUEST
+    {
+        Dummy = 0,
+        Struct1
+    };
+    internal enum EVENT
+    {
+        RECUR_1SEC,
+    }
+    internal enum REQUESTS
+    {
+        SIMULATION,
+        AIRCRAFT_LOADED,
+    }
+}

SimListener/Track.cs

@@ -1,6 +1,6 @@
 namespace SimListener
 {
-    public class Track : IEquatable<Track>
+    public class Track
     {
         private double latitude = 0;
         private double longitude = 0;
@@ -32,46 +32,6 @@ public string Heading
             get => heading.ToString();
             set => _ = double.TryParse(value, out heading);
         }
-
-        public override bool Equals(object? obj)
-        {
-            return obj is not null && Equals(obj as Track);
-        }
-
-        public bool Equals(Track? other)
-        {
-            return other is not null
-&& latitude == other.latitude &&
-                   longitude == other.longitude &&
-                   altitude == other.altitude &&
-                   airspeed == other.airspeed &&
-                   heading == other.heading;
-        }
-
-        public override int GetHashCode()
-        {
-            return HashCode.Combine(latitude, longitude, altitude, airspeed, heading);
-        }
-
-        public override string ToString()
-        {
-            return "Lat = " + latitude +
-                   " Long = " + longitude +
-                   " Alt = " + altitude +
-                   " Speed = " + airspeed +
-                   " Head = " + heading;
-        }
-
-        public static bool operator ==(Track left, Track right)
-        {
-            return EqualityComparer<Track>.Default.Equals(left, right);
-        }
-
-        public static bool operator !=(Track left, Track right)
-        {
-            return !(left == right);
-        }
-
         internal bool Zero()
         {
             return latitude == 0 && longitude == 0 && altitude == 0 && airspeed == 0 && heading == 0;