Updates Upgrade command to check if local version matches latest before downloading/installing #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re downloading/installing
|
Review changes with |
JohnPhamous
deleted the
johnphamous/eng-1096-cli-should-check-for-latest-version-before-installing
branch
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced the CLI's upgrade command with version checking functionality to prevent unnecessary installations and improve user experience.
- Added
getIsOnLatestVersionfunction in/src/lib/upgrade.tsto check current version against GitHub's latest release - Implemented version existence validation before upgrade attempts using GitHub API
- Added early exit conditions when user is already on requested version
- Integrated with existing version display system from
/src/checkVersion.tsfor consistent version checking
💡 (5/5) You can turn off certain types of comments like style here!
1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
|
|
||
| const latestVersionUrl = | ||
| "https://api.github.com/repos/sfcompute/cli/releases/latest"; | ||
| const latestVersionResponse = await fetch(latestVersionUrl); |
There was a problem hiding this comment.
logic: missing try/catch around fetch - network errors will cause uncaught exceptions
Comment on lines
+17
to
+18
| const latestVersionData = await latestVersionResponse.json(); | ||
| const latestVersion = latestVersionData.tag_name; |
There was a problem hiding this comment.
logic: missing try/catch around json parsing and accessing tag_name - malformed response will throw
| const latestVersionData = await latestVersionResponse.json(); | ||
| const latestVersion = latestVersionData.tag_name; | ||
|
|
||
| return latestVersion === currentVersion; |
There was a problem hiding this comment.
style: version comparison should use semver library for proper version string comparison
JohnPhamous
restored the
johnphamous/eng-1096-cli-should-check-for-latest-version-before-installing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.