-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks for mutually-exclusive sf orders ls
flags
#66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added validation checks for mutually exclusive flags in order listing and improved code formatting across the codebase.
- Added flag validation in
src/lib/orders/index.tsx
to prevent incompatible combinations like--public
with--only-filled
or--only-open
with--only-cancelled
- Updated
src/schema.ts
to reflect mutually exclusive flag constraints in the API interface for order query parameters - Clarified
--public
flag description to indicate it implies--only-open
in order listing - Improved code formatting consistency with trailing commas and proper line wrapping across multiple files
- Enhanced error messages to be more descriptive when incompatible flags are used together
32 file(s) reviewed, 10 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main issue is using commander.js
more, otherwise some nits that you can take or leave (ofc I prefer take but otherwise it's whatever)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
sf orders ls
flags
sf orders ls
--public
description indicating that--public
only includes open ordersdeno fmt
deno fmt
anddeno check