Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/correction of ev charger status (Manual, Auto, Scheduled) #302

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Bugfix/correction of ev charger status (Manual, Auto, Scheduled) #302

merged 1 commit into from
Feb 28, 2025
+3 −3

Conversation

rattkin
Copy link
Contributor

@rattkin rattkin commented Feb 28, 2025

fix again #241 since previous PR owner is not responding

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format custom_components/victron)

@rattkin
Update const.py
7941ba5 
fix again sfstar#241 since previous PR owner is not responding
@rattkin rattkin changed the title Update const.py correction of ev charger status (Manual, Auto, Scheduled) Feb 28, 2025
@rattkin rattkin changed the title correction of ev charger status (Manual, Auto, Scheduled) Bugfix/correction of ev charger status (Manual, Auto, Scheduled) Feb 28, 2025
@sfstar sfstar added specsheet mismatch Issue related to the mismatch between the victron specsheet and the actual implementation. minor This PR causes a minor version bump in the version number. bugfix Inconsistencies or issues which will cause a problem for users or implementors. labels Feb 28, 2025
sfstar
sfstar approved these changes Feb 28, 2025
View reviewed changes
Copy link
Owner

@sfstar sfstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfstar sfstar merged commit 8722533 into sfstar:main Feb 28, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfstar sfstar sfstar approved these changes

Assignees
No one assigned
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors. minor This PR causes a minor version bump in the version number. specsheet mismatch Issue related to the mismatch between the victron specsheet and the actual implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rattkin @sfstar