Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] FEAT: 유저리스트 정렬 관리 #161 #171

Merged
merged 13 commits into from
Feb 17, 2025
Merged

[FE] FEAT: 유저리스트 정렬 관리 #161 #171

merged 13 commits into from
Feb 17, 2025

Conversation

juwon5272
Copy link
Collaborator

해당 사항 (중복 선택)

  • FEAT : 새로운 기능 추가 및 개선
  • FIX : 기존 기능 수정 및 정상 동작을 위한 간단한 추가, 수정사항
  • BUG : 버그 수정
  • REFACTOR : 결과의 변경 없이 코드의 구조를 재조정
  • TEST : 테스트 코드 추가
  • DOCS : 코드가 아닌 문서를 수정한 경우
  • REMOVE : 파일을 삭제하는 작업만 수행
  • RENAME : 파일 또는 폴더명을 수정하거나 위치(경로)를 변경
  • ETC : 이외에 다른 경우 - 어떠한 사항인지 작성해주세요.

설명

🔗 관련 이슈

해결한 이슈: closed #161

📝 작업 내용

  • 유저 새로 추가되어도 정렬 유지하게 구현
    • 레드블랙트리로 관리
  • 유저리스트와 보이스챗 나누기
  • switch문 객체리터럴로 바꾸기

📸 스크린샷(optional)

2025-02-14.9.52.14.mov

@juwon5272 juwon5272 added FEAT 새로운 기능 추가 및 개선 🖥️FE 프론트엔드 작업 labels Feb 14, 2025
@juwon5272 juwon5272 added this to the 킥튜브 마일스톤 1 milestone Feb 14, 2025
@juwon5272 juwon5272 self-assigned this Feb 14, 2025
dahyun24
dahyun24 approved these changes Feb 15, 2025
View reviewed changes
Copy link
Collaborator

@dahyun24 dahyun24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

42inshin
42inshin reviewed Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@42inshin 42inshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

만나서 직접 피드백한 내용 기록을 위해서 작성합니다!

  • useUserList 훅은 MemberList 내에서만 사용할 것 같아서 utils에 있기보단 MemberList 내에 구성하는 게 더 나을 것 같습니다.
  • MemberList 와 useUserList 중 member, user 혼용된 네이밍을 통일하면 좋을 것 같아요!

42inshin
42inshin reviewed Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@42inshin 42inshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 코멘트 확인해주세요!

src/frontend/src/components/Sidebar/VoiceChat/index.tsx Outdated Show resolved Hide resolved
src/frontend/src/components/Sidebar/MemberList/index.tsx Outdated Show resolved Hide resolved
42inshin
42inshin approved these changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@42inshin 42inshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 고생하셨습니다!

@juwon5272 juwon5272 merged commit 1612647 into dev Feb 17, 2025
1 check passed
@juwon5272 juwon5272 deleted the fe/dev/feat_userlist/#161 branch February 17, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42inshin 42inshin 42inshin approved these changes

@dahyun24 dahyun24 dahyun24 approved these changes

Assignees

@juwon5272 juwon5272

Labels
🖥️FE 프론트엔드 작업 FEAT 새로운 기능 추가 및 개선
Projects
None yet
Milestone
킥튜브 마일스톤 1
Development

Successfully merging this pull request may close these issues.

[FE] FEAT: 유저리스트 관리
3 participants
@juwon5272 @42inshin @dahyun24