Add the option to pass in a custom port #13
Conversation
|
Will have a closer look at it later and probably merge. But wouldn't it be easier to write a ssh config entry for the build host? |
| .arg(if port.is_some() { | ||
| format!("-e ssh -p {}", port.clone().unwrap()) | ||
| } else { | ||
| "".to_string() |
There was a problem hiding this comment.
That's a bit of an ugly hack. You could use .args() here, which accepts T: IntoIterator<…>. Option does implement IntoIterator (just map the port).
| long = "port", | ||
| help = "Custom port for ssh on the build server" | ||
| )] | ||
| port: Option<String>, |
There was a problem hiding this comment.
This should be Option<u16>, a String allows too many invalid inputs. This would also make port Copy, avoiding al these clone()s.
|
Wouldn't it be better if the port is stored in the config? |
|
@TheAlgorythm tbh I had totally forgotten there was a config file. You are right that that is probably the better place for it. I'm still not sure why you wouldn't just define a host in your ssh config though as cargo remote will probably never support all ssh options.
Yes, definitely, I'm not sure why I didn't do it this way back then tbh. |
We run ssh on a custom port so we needed a way to tell cargo remote to use that port instead. I don't usually write Rust so I don't know if this is the most ergonomic solution. Opening mostly for awareness.
I also ran
cargo fmtwhich formatted some of the lines that I did not change.