Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imrodmartin patch 6 #320

Open
wants to merge 136 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
136 commits
Select commit Hold shift + click to select a range
50e1c02
Update .gitpod.yml
imrodmartin Apr 14, 2022
0b162d9
Update README.md
imrodmartin Apr 14, 2022
30f517a
Update README.md
imrodmartin Apr 14, 2022
59fb45b
Update README.md
imrodmartin Apr 14, 2022
bbeb451
Update README.md
imrodmartin Apr 14, 2022
6c386ad
Update README.md
imrodmartin Apr 14, 2022
f6aedca
Update README.md
imrodmartin Apr 14, 2022
1ab87e8
Update README.md
imrodmartin Apr 14, 2022
f974cea
Update README.md
imrodmartin Apr 14, 2022
49b88d7
Update .gitpod.yml
imrodmartin Apr 25, 2022
c7fc8e7
Update .gitpod.yml
imrodmartin Apr 25, 2022
7c3a773
Update README.md
imrodmartin Apr 25, 2022
4b0c2b1
Update README.md
imrodmartin Apr 25, 2022
e0064f0
Update README.md
imrodmartin Apr 25, 2022
b84e376
Update .gitpod.yml
imrodmartin May 4, 2022
0268094
Update .gitpod.yml
imrodmartin May 4, 2022
19696ac
Update .gitpod.yml
imrodmartin May 4, 2022
9bd587a
Update README.md
imrodmartin May 4, 2022
94d4116
Update .gitpod.yml
imrodmartin May 9, 2022
469f831
Update .gitpod.yml
imrodmartin May 9, 2022
0f89a20
Update .gitpod.yml
imrodmartin May 9, 2022
afc8e71
Update .gitpod.yml
imrodmartin May 9, 2022
c7c04c6
Update composer.lock
imrodmartin May 19, 2022
6744126
Update .gitpod.yml
imrodmartin May 20, 2022
e7d4f45
Create docker-compose.network-mtu.yaml
imrodmartin May 24, 2022
4fc3997
Update .gitpod.yml
imrodmartin May 24, 2022
6ae6fed
Update composer.lock
imrodmartin Jun 13, 2022
4abed2a
Update .gitpod.yml
imrodmartin Jun 13, 2022
acef4eb
Update composer.lock
imrodmartin Jun 23, 2022
dbf54df
Update .gitpod.yml
imrodmartin Jun 23, 2022
cc07587
Update README.md
imrodmartin Jun 23, 2022
bde6528
Update README.md
imrodmartin Jul 6, 2022
417093c
Update README.md
imrodmartin Jul 6, 2022
1997ca3
Update README.md
imrodmartin Jul 6, 2022
bd9c23b
Update launch.json
imrodmartin Jul 14, 2022
4a27263
Update .gitpod.yml
imrodmartin Jul 14, 2022
5535052
Update composer.lock
imrodmartin Aug 1, 2022
8d7be7d
Update .gitpod.yml
imrodmartin Aug 1, 2022
1924487
Update composer.lock
imrodmartin Aug 17, 2022
be1e797
Update .gitpod.yml
imrodmartin Sep 1, 2022
fba9c3c
Update .gitpod.yml
imrodmartin Sep 1, 2022
7057e20
Create composer-provus.json
imrodmartin Sep 1, 2022
bbed917
Update composer.json
imrodmartin Sep 1, 2022
68155dc
Update composer.lock
imrodmartin Sep 1, 2022
0d5e81d
Update composer.json
imrodmartin Sep 1, 2022
21dcab9
Update composer.lock
imrodmartin Sep 1, 2022
9e95ad9
Update README.md
imrodmartin Sep 13, 2022
b94fadf
Update README.md
imrodmartin Sep 13, 2022
412d98f
Update README.md
imrodmartin Oct 5, 2022
bcb8e59
update php to 8.1
imrodmartin Nov 2, 2022
1d859f6
Update composer.lock
imrodmartin Nov 14, 2022
576ac34
Update .gitpod.yml
imrodmartin Nov 14, 2022
905da22
Update default.services.yml
imrodmartin Nov 14, 2022
8f42740
Update default.settings.php
imrodmartin Jan 2, 2023
95f00a2
Update default.services.yml
imrodmartin Jan 2, 2023
658316c
Update settings.php
imrodmartin Jan 2, 2023
6e3250a
Create services.yml
imrodmartin Jan 2, 2023
5a46847
Update services.yml
imrodmartin Jan 2, 2023
b287a1c
Update settings.php
imrodmartin Jan 2, 2023
48199ef
Update config.yaml
imrodmartin Jan 10, 2023
afb85d8
Delete composer-provus.json
imrodmartin Jan 10, 2023
1cc2719
Update composer.json
imrodmartin Feb 3, 2023
fa626c3
Update composer.lock
imrodmartin Feb 3, 2023
84d9f5c
Update composer.json
imrodmartin Feb 3, 2023
4208589
Update composer.lock
imrodmartin Feb 3, 2023
ced815b
Update composer.lock
imrodmartin Feb 3, 2023
526fe5b
Update composer.lock
imrodmartin Feb 3, 2023
eef0520
Update config.yaml
imrodmartin Feb 3, 2023
1f5ce2c
Update composer.lock
imrodmartin Feb 3, 2023
e656b8e
Update composer.json
imrodmartin Feb 3, 2023
d5e722b
Update config.yaml
imrodmartin Feb 3, 2023
6401bac
Update to Drupal 10
imrodmartin Feb 3, 2023
e5c03e6
Update composer.lock
imrodmartin Feb 3, 2023
4134a30
update to composer 2.1
imrodmartin Feb 3, 2023
dfe290f
Merge branch 'main' of https://github.com/imrodmartin/ddev-gitpod int…
imrodmartin Feb 3, 2023
0e2bab7
Update composer.lock
imrodmartin Feb 3, 2023
73d0a16
Update composer.lock
imrodmartin Feb 3, 2023
9e93916
Update composer.lock
imrodmartin Feb 3, 2023
08eaaa2
Update .gitpod.yml
imrodmartin Feb 3, 2023
7d2caef
Update .gitpod.yml
imrodmartin Feb 3, 2023
06b9694
Update composer.lock
imrodmartin Feb 3, 2023
dcb8192
Update composer.json
imrodmartin Feb 3, 2023
4c2f13e
Update .gitpod.yml
imrodmartin Feb 3, 2023
498604e
Update .gitpod.yml
imrodmartin Feb 3, 2023
b6fc390
Update composer.lock
imrodmartin Feb 3, 2023
ed37e90
Update composer.json
imrodmartin Feb 3, 2023
33e1c21
Update composer.json
imrodmartin Feb 3, 2023
45b6f74
Update .gitpod.yml
imrodmartin Feb 3, 2023
c78a064
Update README.md
imrodmartin Feb 3, 2023
86d8766
Update README.md
imrodmartin Feb 3, 2023
2e52cb9
Update .gitpod.yml
imrodmartin Jun 1, 2023
625f93c
Update .gitpod.yml
imrodmartin Jun 1, 2023
935801e
Update .gitpod.yml
imrodmartin Jun 1, 2023
ee0b491
fix: committing previous file changes
shaal Jun 6, 2023
f2fef32
fix: update to latest image base
shaal Jun 6, 2023
b6f55c9
fix: use core-recommended instead of core
shaal Jun 6, 2023
c83d8f9
Merge pull request #3 from imrodmartin/composer-fix
imrodmartin Jun 6, 2023
6b3801b
composer update
shaal Jun 6, 2023
f7a6a70
Merge pull request #4 from imrodmartin/composer-update
imrodmartin Jun 6, 2023
07d9c23
Update .gitpod.yml
imrodmartin Jun 7, 2023
c30ed7e
Update .gitpod.yml
imrodmartin Jun 26, 2023
cd55b70
Merge pull request #5 from imrodmartin/imrodmartin-patch-2
imrodmartin Jun 26, 2023
b0ef5bf
Update .gitpod.yml
imrodmartin Jul 11, 2023
b72175f
Update README.md
imrodmartin Sep 20, 2023
99e956d
Update README.md
imrodmartin Sep 20, 2023
0f574e6
Update .gitpod.yml
imrodmartin Nov 29, 2023
3bf42e6
Update composer.json
imrodmartin Dec 2, 2023
dd44adb
Update composer.json
imrodmartin Dec 2, 2023
5852122
Update .gitpod.yml
imrodmartin Feb 4, 2024
6cf6d08
Update config.yaml
imrodmartin Feb 4, 2024
377ed55
Update composer.json
imrodmartin Feb 4, 2024
24c03be
Update composer.lock
imrodmartin Feb 4, 2024
5311bc2
Update composer.lock
imrodmartin Feb 4, 2024
a11d51d
Update .gitpod.yml
imrodmartin Feb 4, 2024
abd236e
Update composer.json
imrodmartin Feb 4, 2024
6b6bfd3
Update composer.json
imrodmartin Mar 21, 2024
8480768
Update composer.lock
imrodmartin Mar 21, 2024
1200508
Update composer.json
imrodmartin Jul 1, 2024
ffd0eaa
Update .gitpod.yml
imrodmartin Jul 1, 2024
130a6b2
Update .gitpod.yml
imrodmartin Jul 1, 2024
7e6cee1
Update README.md
imrodmartin Jul 15, 2024
99a0877
Update README.md
imrodmartin Jul 15, 2024
0a7285f
Update config.yaml to use php 8.3
imrodmartin Oct 9, 2024
ed8795f
Update composer.json - moved to D11
imrodmartin Nov 11, 2024
043f128
Rename composer.lock to composer_old.lock
imrodmartin Nov 11, 2024
fd204a1
Update composer.json
imrodmartin Nov 11, 2024
ff2fbf4
Update and rename composer_old.lock to composer.lock
imrodmartin Nov 11, 2024
973f792
Update config.yaml
imrodmartin Nov 11, 2024
e9d0665
Update config.yaml
imrodmartin Nov 11, 2024
76acb18
Update composer.json - reverted to 10
imrodmartin Nov 11, 2024
5ad063c
Update composer.lock
imrodmartin Nov 11, 2024
bf1483b
Update README.md
imrodmartin Nov 11, 2024
5b89a25
Update config.yaml - mysql
imrodmartin Nov 11, 2024
f3f06a7
Update config.yaml
imrodmartin Nov 11, 2024
1e7eb59
Update .gitpod.yml
imrodmartin Nov 14, 2024
ab17f30
Update composer.json
imrodmartin Dec 4, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 88 additions & 25 deletions .ddev/config.yaml
Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
name: ddev-gitpod
type: drupal9
type: drupal10
docroot: web
php_version: "8.0"
php_version: "8.3"
webserver_type: nginx-fpm
router_http_port: "80"
router_https_port: "443"
xdebug_enabled: false
additional_hostnames: []
additional_fqdns: []
mariadb_version: "10.3"
mysql_version: ""
database:
type: mariadb
version: "10.4"
Comment on lines +11 to +13
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider upgrading MariaDB version

MariaDB 10.4 is relatively old. For Drupal 10, consider using MariaDB 10.6 or newer for better performance and security features.

 database:
   type: mariadb
-  version: "10.4"
+  version: "10.6"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
database:
type: mariadb
version: "10.4"
database:
type: mariadb
version: "10.6"

nfs_mount_enabled: false
mutagen_enabled: false
use_dns_when_possible: true
composer_version: ""
composer_version: "2"
web_environment: []
nodejs_version: "16"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Update Node.js version

Node.js 16 reaches End-of-Life in September 2024. Consider upgrading to Node.js 18 LTS or 20 LTS for long-term support and security updates.

-nodejs_version: "16"
+nodejs_version: "20"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
nodejs_version: "16"
nodejs_version: "20"


# Key features of ddev's config.yaml:

Expand All @@ -25,21 +27,19 @@ web_environment: []

# docroot: <relative_path> # Relative path to the directory containing index.php.

# php_version: "7.4" # PHP version to use, "5.6", "7.0", "7.1", "7.2", "7.3", "7.4", "8.0", "8.1"
# php_version: "7.4" # PHP version to use, "5.6", "7.0", "7.1", "7.2", "7.3", "7.4", "8.0", "8.1", "8.2"

# You can explicitly specify the webimage, dbimage, dbaimage lines but this
# You can explicitly specify the webimage but this
# is not recommended, as the images are often closely tied to ddev's' behavior,
# so this can break upgrades.

# webimage: <docker_image> # nginx/php docker image.
# dbimage: <docker_image> # mariadb docker image.
# dbaimage: <docker_image>

# mariadb_version and mysql_version
# ddev can use many versions of mariadb and mysql
# However these directives are mutually exclusive
# mariadb_version: 10.2
# mysql_version: 8.0
# database:
# type: <dbtype> # mysql, mariadb
# version: <version> # database version, like "10.3" or "8.0"
# Note that mariadb_version or mysql_version from v1.18 and earlier
# will automatically be converted to this notation with just a "ddev config --auto"

# router_http_port: <port> # Port to be used for http (defaults to port 80)
# router_https_port: <port> # Port for https (defaults to 443)
Expand All @@ -62,12 +62,26 @@ web_environment: []
# see https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
# For example Europe/Dublin or MST7MDT

# composer_root: <relative_path>
# Relative path to the composer root directory from the project root. This is
# the directory which contains the composer.json and where all Composer related
# commands are executed.

# composer_version: "2"
# if composer_version:"2" it will use the most recent composer v2
# It can also be set to "1", to get most recent composer v1
# or "" for the default v2 created at release time.
# It can be set to any existing specific composer version.
# After first project 'ddev start' this will not be updated until it changes
# You can set it to "" or "2" (default) for Composer v2 or "1" for Composer v1
# to use the latest major version available at the time your container is built.
# It is also possible to use each other Composer version channel. This includes:
# - 2.2 (latest Composer LTS version)
# - stable
# - preview
# - snapshot
# Alternatively, an explicit Composer version may be specified, for example "2.2.18".
# To reinstall Composer after the image was built, run "ddev debug refresh".

# nodejs_version: "16"
# change from the default system Node.js version to another supported version, like 12, 14, 17, 18.
# Note that you can use 'ddev nvm' or nvm inside the web container to provide nearly any
# Node.js version, including v6, etc.

# additional_hostnames:
# - somename
Expand All @@ -82,7 +96,9 @@ web_environment: []
# Please take care with this because it can cause great confusion.

# upload_dir: custom/upload/dir
# would set the destination path for ddev import-files to <docroot>/custom/upload/dir
# would set the destination path for ddev import-files to <docroot>/custom/upload/dir
# When mutagen is enabled this path is bind-mounted so that all the files
# in the upload_dir don't have to be synced into mutagen

# working_dir:
# web: /var/www/html
Expand All @@ -100,11 +116,11 @@ web_environment: []

# nfs_mount_enabled: false
# Great performance improvement but requires host configuration first.
# See https://ddev.readthedocs.io/en/stable/users/performance/#using-nfs-to-mount-the-project-into-the-container
# See https://ddev.readthedocs.io/en/latest/users/install/performance/#nfs

# mutagen_enabled: false
# Experimental performance improvement using mutagen asynchronous updates.
# See https://ddev.readthedocs.io/en/latest/users/performance/#using-mutagen
# Performance improvement using mutagen asynchronous updates.
# See https://ddev.readthedocs.io/en/latest/users/install/performance/#mutagen

# fail_on_hook_fail: False
# Decide whether 'ddev start' should be interrupted by a failing hook
Expand Down Expand Up @@ -159,7 +175,7 @@ web_environment: []
# If you prefer you can change this to "ddev.local" to preserve
# pre-v1.9 behavior.

# ngrok_args: --subdomain mysite --auth username:pass
# ngrok_args: --basic-auth username:pass1234
# Provide extra flags to the "ngrok http" command, see
# https://ngrok.com/docs#http or run "ngrok http -h"

Expand All @@ -185,10 +201,57 @@ web_environment: []
# will be available on the local network if the host firewall
# allows it.

# default_container_timeout: 120
# The default time that ddev waits for all containers to become ready can be increased from
# the default 120. This helps in importing huge databases, for example.

#web_extra_exposed_ports:
#- name: nodejs
# container_port: 3000
# http_port: 2999
# https_port: 3000
#- name: something
# container_port: 4000
# https_port: 4000
# http_port: 3999
# Allows a set of extra ports to be exposed via ddev-router
# The port behavior on the ddev-webserver must be arranged separately, for example
# using web_extra_daemons.
# For example, with a web app on port 3000 inside the container, this config would
# expose that web app on https://<project>.ddev.site:9999 and http://<project>.ddev.site:9998
# web_extra_exposed_ports:
# - container_port: 3000
# http_port: 9998
# https_port: 9999

#web_extra_daemons:
#- name: "http-1"
# command: "/var/www/html/node_modules/.bin/http-server -p 3000"
# directory: /var/www/html
#- name: "http-2"
# command: "/var/www/html/node_modules/.bin/http-server /var/www/html/sub -p 3000"
# directory: /var/www/html

# override_config: false
# By default, config.*.yaml files are *merged* into the configuration
# But this means that some things can't be overridden
# For example, if you have 'nfs_mount_enabled: true'' you can't override it with a merge
# and you can't erase existing hooks or all environment variables.
# However, with "override_config: true" in a particular config.*.yaml file,
# 'nfs_mount_enabled: false' can override the existing values, and
# hooks:
# post-start: []
# or
# web_environment: []
# or
# additional_hostnames: []
# can have their intended affect. 'override_config' affects only behavior of the
# config.*.yaml file it exists in.

# Many ddev commands can be extended to run tasks before or after the
# ddev command is executed, for example "post-start", "post-import-db",
# "pre-composer", "post-composer"
# See https://ddev.readthedocs.io/en/stable/users/extending-commands/ for more
# See https://ddev.readthedocs.io/en/stable/users/extend/custom-commands/ for more
# information on the commands that can be extended and the tasks you can define
# for them. Example:
#hooks:
Expand Down
18 changes: 18 additions & 0 deletions .ddev/docker-compose.network-mtu.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Temporary fix for network issues when running composer inside ddev container (in Gitpod)
#
# Since Gitpod removed slirp4netns as part of performance improvements,
# MTU value should be aligned to the one in gitpod.io
#
# Gitpod fixed it for docker - https://github.com/gitpod-io/gitpod/pull/9356
# and for docker-compose - https://github.com/gitpod-io/template-docker-compose/pull/4
#
# ddev doesn't use Gitpod's custom docker-compose binary. Instead, ddev uses
# its own docker-compose binary at /home/gitpod/.ddev/bin/docker-compose
# ddev issue [WIP] - https://github.com/drud/ddev/issues/3766
#
# Align the MTU value to the one that is set in Gitpod (1440)

networks:
default:
driver_opts:
com.docker.network.driver.mtu: 1440
16 changes: 8 additions & 8 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -19,24 +19,24 @@
*.config text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
*.css text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
*.dist text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
*.engine text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php
*.engine text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php
*.html text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=html
*.inc text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php
*.install text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php
*.inc text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php
*.install text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php
*.js text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
*.json text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
*.lock text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
*.map text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
*.md text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
*.module text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php
*.php text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php
*.module text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php
*.php text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php
*.po text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
*.profile text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php
*.profile text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php
*.script text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
*.sh text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php
*.sh text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove incorrect language attribute for shell scripts

Shell scripts should not be marked as PHP files.

Apply this diff to fix the shell script attribute:

-*.sh      text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php
+*.sh      text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
*.sh text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php
*.sh text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2

*.sql text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
*.svg text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
*.theme text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php
*.theme text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php
*.twig text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
*.txt text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
*.xml text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2
Expand Down
31 changes: 7 additions & 24 deletions .gitpod.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
image: drupalpod/drupalpod-gitpod-base:20220322

image: drupalpod/drupalpod-gitpod-base:20240905
# ddev and composer are running as part of the prebuild
# when starting a workspace all docker images are ready
tasks:
- init: |
ddev start -y
ddev composer install
ddev drush si -y --account-pass=admin --site-name='ddev_gitpod' demo_umami
ddev drush si -y --account-pass=admin --site-name='Drupal Training'
command: |
ddev start -y
gp await-port 8080 && gp preview $(gp url 8080)
gp ports await 8080 && gp preview $(gp url 8080)
ddev composer update
ddev drush updb -y
ddev drush cr

# VScode xdebug extension
vscode:
Expand Down Expand Up @@ -43,27 +45,8 @@ ports:
- port: 8443
onOpen: ignore
# xdebug port
- port: 9000
- port: 9003
onOpen: ignore
# projector port
- port: 9999
onOpen: open-browser

github:
prebuilds:
# enable for the master/default branch (defaults to true)
master: true
# enable for all branches in this repo (defaults to false)
branches: true
# enable for pull requests coming from this repo (defaults to true)
pullRequests: true
# enable for pull requests coming from forks (defaults to false)
pullRequestsFromForks: true
# add a check to pull requests (defaults to true)
addCheck: true
# add a "Review in Gitpod" button as a comment to pull requests (defaults to false)
addComment: false
# add a "Review in Gitpod" button to the pull request's description (defaults to false)
addBadge: true
# add a label once the prebuild is ready to pull requests (defaults to false)
addLabel: true
4 changes: 2 additions & 2 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
"type": "php",
"request": "launch",
"hostname": "0.0.0.0",
"port": 9000,
"port": 9003,
"pathMappings": {
"/var/www/html": "${workspaceRoot}"
}
}
]
}
}
42 changes: 11 additions & 31 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,49 +1,29 @@
[![Gitpod ready-to-code](https://img.shields.io/badge/Gitpod-ready--to--code-blue?logo=gitpod)](https://gitpod.io/#https://github.com/shaal/ddev-gitpod)

# ddev + Gitpod
## Set up a full Drupal dev environment in a browser
## Set up a full Drupal dev environment in a browser (now using Drupal 10!)

This project demonstrates a complete Drupal 9 development environment, utilizing ddev and Gitpod, through your browser.
This project demonstrates a <strong>complete Drupal 10</strong> development environment, utilizing ddev and Gitpod, through your browser.

## Video Demo
## This is a branch from @shaal - creates a blank Drupal site instead of a Unami Demo ##

Watch a 5 minutes walkthrough video:
## Video Demo

<a href="http://www.youtube.com/watch?v=ifk5dF6rGy0"><img src="https://user-images.githubusercontent.com/22901/107867673-c6fc7080-6e4a-11eb-81c9-542cd779026b.png" width=300 alt="Setup a full Drupal dev environment in a browser"></a>
<a href="https://vimeo.com/699619764" target="_blank"><img src="https://imrodmartin.com/sites/default/files/2023-09/cover-github-repo.jpg"></a>

## Prerequisites:
1. [Sign up for gitpod.io](https://gitpod.io/login)
1. [Sign up for gitpod.io](https://gitpod.io/login) - **USE A GITHUB ACCOUNT**

## Try it out:
1. Click on the following link
https://gitpod.io/#https://github.com/shaal/ddev-gitpod
<a href="https://gitpod.io/#https://github.com/imrodmartin/ddev-gitpod" target="_blank">https://gitpod.io/#https://github.com/imrodmartin/ddev-gitpod</a>
1. Your environment is being prepared, wait about 40 seconds (A splash screen will appear)
1. VScode IDE will be displayed, a few seconds later you will see Umami demo.
1. Run in terminal `ddev xdebug on`
1. Open VScode's debugger, place a new breakpoint in `web/index.php`
1. Open your website's URL in a browser.
1. :tada:

## Do you like PhpStorm instead of Theia or VScode?
1. Open a bash window at the bottom
2. `.ddev/run-phpstorm.sh`

## How does it work?
1. Gitpod - development environment based on Docker
1. [.gitpod.yml](https://github.com/shaal/ddev-gitpod/blob/main/.gitpod.yml)
1. Defines the main docker image this environment is built on - `.gitpod.Dockerfile`
1. Run prebuild commands:
1. Start ddev
1. Run `composer install`
1. Install Umami demo website
1. [.gitpod.Dockerfile](https://github.com/shaal/ddev-gitpod/blob/main/.gitpod.Dockerfile)
1. Set base image to Gitpod's `workspace-full` ([link](https://github.com/gitpod-io/workspace-images/tree/master/full))
1. Install ddev using brew
1. ddev - ridiculously simple setup for complex development environments, allows developers working locally or working with Gitpod in the cloud.
1. [.ddev/config.yaml](https://github.com/shaal/ddev-gitpod/blob/main/.ddev/config.yaml) - main ddev (default) configuration, can be generated by running `ddev config`
2. VScode IDE will be displayed, a few seconds later you will see a fresh blank Drupal site.
3. Open your website's URL in a browser (at the bottom of the terminal window)
4. :tada:

## Thank you
[@rfay](https://github.com/rfay) for your endless patience and relentless support that made this project possible.
[@shaal](https://github.com/shaal) A HUGE thank you to Offer Shaal for his work on this and continued help!

### Persistent Storage:
* Gitpod backs up the state of the `/workspace/` folder between workspace starts, so that you can revisit them later. Attention: Files in other locations will not be saved!
Expand Down
Loading