-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imrodmartin patch 6 #320
base: main
Are you sure you want to change the base?
Imrodmartin patch 6 #320
Changes from all commits
50e1c02
0b162d9
30f517a
59fb45b
bbeb451
6c386ad
f6aedca
1ab87e8
f974cea
49b88d7
c7fc8e7
7c3a773
4b0c2b1
e0064f0
b84e376
0268094
19696ac
9bd587a
94d4116
469f831
0f89a20
afc8e71
c7c04c6
6744126
e7d4f45
4fc3997
6ae6fed
4abed2a
acef4eb
dbf54df
cc07587
bde6528
417093c
1997ca3
bd9c23b
4a27263
5535052
8d7be7d
1924487
be1e797
fba9c3c
7057e20
bbed917
68155dc
0d5e81d
21dcab9
9e95ad9
b94fadf
412d98f
bcb8e59
1d859f6
576ac34
905da22
8f42740
95f00a2
658316c
6e3250a
5a46847
b287a1c
48199ef
afb85d8
1cc2719
fa626c3
84d9f5c
4208589
ced815b
526fe5b
eef0520
1f5ce2c
e656b8e
d5e722b
6401bac
e5c03e6
4134a30
dfe290f
0e2bab7
73d0a16
9e93916
08eaaa2
7d2caef
06b9694
dcb8192
4c2f13e
498604e
b6fc390
ed37e90
33e1c21
45b6f74
c78a064
86d8766
2e52cb9
625f93c
935801e
ee0b491
f2fef32
b6f55c9
c83d8f9
6b3801b
f7a6a70
07d9c23
c30ed7e
cd55b70
b0ef5bf
b72175f
99e956d
0f574e6
3bf42e6
dd44adb
5852122
6cf6d08
377ed55
24c03be
5311bc2
a11d51d
abd236e
6b6bfd3
8480768
1200508
ffd0eaa
130a6b2
7e6cee1
99a0877
0a7285f
ed8795f
043f128
fd204a1
ff2fbf4
973f792
e9d0665
76acb18
5ad063c
bf1483b
5b89a25
f3f06a7
1e7eb59
ab17f30
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,20 +1,22 @@ | ||||||
name: ddev-gitpod | ||||||
type: drupal9 | ||||||
type: drupal10 | ||||||
docroot: web | ||||||
php_version: "8.0" | ||||||
php_version: "8.3" | ||||||
webserver_type: nginx-fpm | ||||||
router_http_port: "80" | ||||||
router_https_port: "443" | ||||||
xdebug_enabled: false | ||||||
additional_hostnames: [] | ||||||
additional_fqdns: [] | ||||||
mariadb_version: "10.3" | ||||||
mysql_version: "" | ||||||
database: | ||||||
type: mariadb | ||||||
version: "10.4" | ||||||
nfs_mount_enabled: false | ||||||
mutagen_enabled: false | ||||||
use_dns_when_possible: true | ||||||
composer_version: "" | ||||||
composer_version: "2" | ||||||
web_environment: [] | ||||||
nodejs_version: "16" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Update Node.js version Node.js 16 reaches End-of-Life in September 2024. Consider upgrading to Node.js 18 LTS or 20 LTS for long-term support and security updates. -nodejs_version: "16"
+nodejs_version: "20" 📝 Committable suggestion
Suggested change
|
||||||
|
||||||
# Key features of ddev's config.yaml: | ||||||
|
||||||
|
@@ -25,21 +27,19 @@ web_environment: [] | |||||
|
||||||
# docroot: <relative_path> # Relative path to the directory containing index.php. | ||||||
|
||||||
# php_version: "7.4" # PHP version to use, "5.6", "7.0", "7.1", "7.2", "7.3", "7.4", "8.0", "8.1" | ||||||
# php_version: "7.4" # PHP version to use, "5.6", "7.0", "7.1", "7.2", "7.3", "7.4", "8.0", "8.1", "8.2" | ||||||
|
||||||
# You can explicitly specify the webimage, dbimage, dbaimage lines but this | ||||||
# You can explicitly specify the webimage but this | ||||||
# is not recommended, as the images are often closely tied to ddev's' behavior, | ||||||
# so this can break upgrades. | ||||||
|
||||||
# webimage: <docker_image> # nginx/php docker image. | ||||||
# dbimage: <docker_image> # mariadb docker image. | ||||||
# dbaimage: <docker_image> | ||||||
|
||||||
# mariadb_version and mysql_version | ||||||
# ddev can use many versions of mariadb and mysql | ||||||
# However these directives are mutually exclusive | ||||||
# mariadb_version: 10.2 | ||||||
# mysql_version: 8.0 | ||||||
# database: | ||||||
# type: <dbtype> # mysql, mariadb | ||||||
# version: <version> # database version, like "10.3" or "8.0" | ||||||
# Note that mariadb_version or mysql_version from v1.18 and earlier | ||||||
# will automatically be converted to this notation with just a "ddev config --auto" | ||||||
|
||||||
# router_http_port: <port> # Port to be used for http (defaults to port 80) | ||||||
# router_https_port: <port> # Port for https (defaults to 443) | ||||||
|
@@ -62,12 +62,26 @@ web_environment: [] | |||||
# see https://en.wikipedia.org/wiki/List_of_tz_database_time_zones | ||||||
# For example Europe/Dublin or MST7MDT | ||||||
|
||||||
# composer_root: <relative_path> | ||||||
# Relative path to the composer root directory from the project root. This is | ||||||
# the directory which contains the composer.json and where all Composer related | ||||||
# commands are executed. | ||||||
|
||||||
# composer_version: "2" | ||||||
# if composer_version:"2" it will use the most recent composer v2 | ||||||
# It can also be set to "1", to get most recent composer v1 | ||||||
# or "" for the default v2 created at release time. | ||||||
# It can be set to any existing specific composer version. | ||||||
# After first project 'ddev start' this will not be updated until it changes | ||||||
# You can set it to "" or "2" (default) for Composer v2 or "1" for Composer v1 | ||||||
# to use the latest major version available at the time your container is built. | ||||||
# It is also possible to use each other Composer version channel. This includes: | ||||||
# - 2.2 (latest Composer LTS version) | ||||||
# - stable | ||||||
# - preview | ||||||
# - snapshot | ||||||
# Alternatively, an explicit Composer version may be specified, for example "2.2.18". | ||||||
# To reinstall Composer after the image was built, run "ddev debug refresh". | ||||||
|
||||||
# nodejs_version: "16" | ||||||
# change from the default system Node.js version to another supported version, like 12, 14, 17, 18. | ||||||
# Note that you can use 'ddev nvm' or nvm inside the web container to provide nearly any | ||||||
# Node.js version, including v6, etc. | ||||||
|
||||||
# additional_hostnames: | ||||||
# - somename | ||||||
|
@@ -82,7 +96,9 @@ web_environment: [] | |||||
# Please take care with this because it can cause great confusion. | ||||||
|
||||||
# upload_dir: custom/upload/dir | ||||||
# would set the destination path for ddev import-files to <docroot>/custom/upload/dir | ||||||
# would set the destination path for ddev import-files to <docroot>/custom/upload/dir | ||||||
# When mutagen is enabled this path is bind-mounted so that all the files | ||||||
# in the upload_dir don't have to be synced into mutagen | ||||||
|
||||||
# working_dir: | ||||||
# web: /var/www/html | ||||||
|
@@ -100,11 +116,11 @@ web_environment: [] | |||||
|
||||||
# nfs_mount_enabled: false | ||||||
# Great performance improvement but requires host configuration first. | ||||||
# See https://ddev.readthedocs.io/en/stable/users/performance/#using-nfs-to-mount-the-project-into-the-container | ||||||
# See https://ddev.readthedocs.io/en/latest/users/install/performance/#nfs | ||||||
|
||||||
# mutagen_enabled: false | ||||||
# Experimental performance improvement using mutagen asynchronous updates. | ||||||
# See https://ddev.readthedocs.io/en/latest/users/performance/#using-mutagen | ||||||
# Performance improvement using mutagen asynchronous updates. | ||||||
# See https://ddev.readthedocs.io/en/latest/users/install/performance/#mutagen | ||||||
|
||||||
# fail_on_hook_fail: False | ||||||
# Decide whether 'ddev start' should be interrupted by a failing hook | ||||||
|
@@ -159,7 +175,7 @@ web_environment: [] | |||||
# If you prefer you can change this to "ddev.local" to preserve | ||||||
# pre-v1.9 behavior. | ||||||
|
||||||
# ngrok_args: --subdomain mysite --auth username:pass | ||||||
# ngrok_args: --basic-auth username:pass1234 | ||||||
# Provide extra flags to the "ngrok http" command, see | ||||||
# https://ngrok.com/docs#http or run "ngrok http -h" | ||||||
|
||||||
|
@@ -185,10 +201,57 @@ web_environment: [] | |||||
# will be available on the local network if the host firewall | ||||||
# allows it. | ||||||
|
||||||
# default_container_timeout: 120 | ||||||
# The default time that ddev waits for all containers to become ready can be increased from | ||||||
# the default 120. This helps in importing huge databases, for example. | ||||||
|
||||||
#web_extra_exposed_ports: | ||||||
#- name: nodejs | ||||||
# container_port: 3000 | ||||||
# http_port: 2999 | ||||||
# https_port: 3000 | ||||||
#- name: something | ||||||
# container_port: 4000 | ||||||
# https_port: 4000 | ||||||
# http_port: 3999 | ||||||
# Allows a set of extra ports to be exposed via ddev-router | ||||||
# The port behavior on the ddev-webserver must be arranged separately, for example | ||||||
# using web_extra_daemons. | ||||||
# For example, with a web app on port 3000 inside the container, this config would | ||||||
# expose that web app on https://<project>.ddev.site:9999 and http://<project>.ddev.site:9998 | ||||||
# web_extra_exposed_ports: | ||||||
# - container_port: 3000 | ||||||
# http_port: 9998 | ||||||
# https_port: 9999 | ||||||
|
||||||
#web_extra_daemons: | ||||||
#- name: "http-1" | ||||||
# command: "/var/www/html/node_modules/.bin/http-server -p 3000" | ||||||
# directory: /var/www/html | ||||||
#- name: "http-2" | ||||||
# command: "/var/www/html/node_modules/.bin/http-server /var/www/html/sub -p 3000" | ||||||
# directory: /var/www/html | ||||||
|
||||||
# override_config: false | ||||||
# By default, config.*.yaml files are *merged* into the configuration | ||||||
# But this means that some things can't be overridden | ||||||
# For example, if you have 'nfs_mount_enabled: true'' you can't override it with a merge | ||||||
# and you can't erase existing hooks or all environment variables. | ||||||
# However, with "override_config: true" in a particular config.*.yaml file, | ||||||
# 'nfs_mount_enabled: false' can override the existing values, and | ||||||
# hooks: | ||||||
# post-start: [] | ||||||
# or | ||||||
# web_environment: [] | ||||||
# or | ||||||
# additional_hostnames: [] | ||||||
# can have their intended affect. 'override_config' affects only behavior of the | ||||||
# config.*.yaml file it exists in. | ||||||
|
||||||
# Many ddev commands can be extended to run tasks before or after the | ||||||
# ddev command is executed, for example "post-start", "post-import-db", | ||||||
# "pre-composer", "post-composer" | ||||||
# See https://ddev.readthedocs.io/en/stable/users/extending-commands/ for more | ||||||
# See https://ddev.readthedocs.io/en/stable/users/extend/custom-commands/ for more | ||||||
# information on the commands that can be extended and the tasks you can define | ||||||
# for them. Example: | ||||||
#hooks: | ||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Temporary fix for network issues when running composer inside ddev container (in Gitpod) | ||
# | ||
# Since Gitpod removed slirp4netns as part of performance improvements, | ||
# MTU value should be aligned to the one in gitpod.io | ||
# | ||
# Gitpod fixed it for docker - https://github.com/gitpod-io/gitpod/pull/9356 | ||
# and for docker-compose - https://github.com/gitpod-io/template-docker-compose/pull/4 | ||
# | ||
# ddev doesn't use Gitpod's custom docker-compose binary. Instead, ddev uses | ||
# its own docker-compose binary at /home/gitpod/.ddev/bin/docker-compose | ||
# ddev issue [WIP] - https://github.com/drud/ddev/issues/3766 | ||
# | ||
# Align the MTU value to the one that is set in Gitpod (1440) | ||
|
||
networks: | ||
default: | ||
driver_opts: | ||
com.docker.network.driver.mtu: 1440 |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -19,24 +19,24 @@ | |||||
*.config text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
*.css text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
*.dist text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
*.engine text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php | ||||||
*.engine text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php | ||||||
*.html text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=html | ||||||
*.inc text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php | ||||||
*.install text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php | ||||||
*.inc text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php | ||||||
*.install text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php | ||||||
*.js text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
*.json text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
*.lock text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
*.map text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
*.md text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
*.module text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php | ||||||
*.php text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php | ||||||
*.module text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php | ||||||
*.php text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php | ||||||
*.po text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
*.profile text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php | ||||||
*.profile text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php | ||||||
*.script text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
*.sh text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php | ||||||
*.sh text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove incorrect language attribute for shell scripts Shell scripts should not be marked as PHP files. Apply this diff to fix the shell script attribute: -*.sh text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php
+*.sh text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 📝 Committable suggestion
Suggested change
|
||||||
*.sql text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
*.svg text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
*.theme text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php | ||||||
*.theme text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 diff=php linguist-language=php | ||||||
*.twig text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
*.txt text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
*.xml text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider upgrading MariaDB version
MariaDB 10.4 is relatively old. For Drupal 10, consider using MariaDB 10.6 or newer for better performance and security features.
📝 Committable suggestion