Move className overwrite of AccordionContent to the children component #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to have a smooth opening of the accordion, moving the AccordionContent className overwrite to the children wrapper component allow Radix to calculate correctly the animation and execute a smooth animation in case of className on the AccordionContent. Possibly related to shadcn-ui#944
|
@shug0 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Demo CodeLaggy demo (current implementation)laggy.mp4Smooth demo (suggested changes)smooth.mp4 |
SoyDiego
approved these changes
Oct 4, 2023
|
Agreed. |
shadcn
added
bug
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shadcn
approved these changes
Nov 12, 2023
|
Fixes #944 |
kjxbyz
pushed a commit
to muse-ui/muse-ui
that referenced
this pull request
Jun 7, 2024
shadcn-ui#1670) In order to have a smooth opening of the accordion, moving the `AccordionContent` `className` overwrite to the children wrapper component allow Radix to calculate correctly the animation and execute a smooth animation in case of `className` on the `AccordionContent` component. Possibly related to shadcn-ui#944
artabr
pushed a commit
to artabr/shadcn-ui
that referenced
this pull request
Dec 15, 2024
shadcn-ui#1670) In order to have a smooth opening of the accordion, moving the `AccordionContent` `className` overwrite to the children wrapper component allow Radix to calculate correctly the animation and execute a smooth animation in case of `className` on the `AccordionContent` component. Possibly related to shadcn-ui#944
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a smooth opening of the accordion, moving the
AccordionContentclassNameoverwrite to the children wrapper component allow Radix to calculate correctly the animation and execute a smooth animation in case ofclassNameon theAccordionContentcomponent.Possibly related to #944