Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(calendar): updated css so date doesn't show up selected twice in DatePickerComponent #1852

Merged
merged 3 commits into from
Nov 12, 2023

Conversation

tanishbaansal
Copy link
Contributor

React Day Picker also has a unique styling distinction that designates the day_outside dates as unselected, and the selection of day_outside only highlights the dates in the next month. This PR will fix this issue - #1762 and help with a cleaner UX ✨


Old Date Range Picker New Date Range Picker
old new

React Day Picker

image

@vercel
Copy link

vercel bot commented Oct 28, 2023

@tanishbaansal is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thank you.

Copy link

vercel bot commented Nov 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 9:32am

@shadcn
Copy link
Collaborator

shadcn commented Nov 12, 2023

@tanishbaansal Can you run pnpm format:write and push again please? Thank you.

@shadcn shadcn added enhancement New feature or request component: calendar area: roadmap This looks great. We'll add it to the roadmap, review and merge. component: datepicker labels Nov 12, 2023
@kodiakhq kodiakhq bot merged commit 3a279a2 into shadcn-ui:main Nov 12, 2023
4 of 5 checks passed
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
…e in DatePickerComponent (shadcn-ui#1852)

React Day Picker also has a unique styling distinction that designates the `day_outside` dates as unselected, and the selection of `day_outside` only highlights the dates in the next month. This PR will fix this issue - shadcn-ui#1762 and help with a cleaner UX ✨

  
<br/>

| Old Date Range Picker  | New Date Range Picker           |
| ---------------------- | ---------------------- |
| ![old](https://github.com/shadcn-ui/ui/assets/7449806/42e9448f-9e38-486c-b65c-cf00ec1ec7c7) | ![new](https://github.com/shadcn-ui/ui/assets/7449806/804f83d7-1b74-474c-8992-2d6d844dfb35) |

<br/>

#### React Day Picker
<img width="444" alt="image" src="https://github.com/shadcn-ui/ui/assets/7449806/aaeae160-b38c-4c16-bb2d-66898cf290d3">
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
…e in DatePickerComponent (shadcn-ui#1852)

React Day Picker also has a unique styling distinction that designates the `day_outside` dates as unselected, and the selection of `day_outside` only highlights the dates in the next month. This PR will fix this issue - shadcn-ui#1762 and help with a cleaner UX ✨

  
<br/>

| Old Date Range Picker  | New Date Range Picker           |
| ---------------------- | ---------------------- |
| ![old](https://github.com/shadcn-ui/ui/assets/7449806/42e9448f-9e38-486c-b65c-cf00ec1ec7c7) | ![new](https://github.com/shadcn-ui/ui/assets/7449806/804f83d7-1b74-474c-8992-2d6d844dfb35) |

<br/>

#### React Day Picker
<img width="444" alt="image" src="https://github.com/shadcn-ui/ui/assets/7449806/aaeae160-b38c-4c16-bb2d-66898cf290d3">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: roadmap This looks great. We'll add it to the roadmap, review and merge. automerge component: calendar component: datepicker enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants