Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cardtitle text overflow #2310

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MohammedAslam106
Copy link

@MohammedAslam106 MohammedAslam106 commented Jan 6, 2024

Fixes #2265
Pull Request: Fix Overflow Issue in Card Title
Issue Addressed:
The pull request aims to resolve the overflow problem occurring specifically for longer texts within the card-title component.

Changes Made:
Adjusted CSS rules for the card-title to prevent overflow when text exceeds the available space.
Incorporated ellipsis (...) for longer texts, ensuring readability without compromising the design.
Images for Reference:
After Overflow Fix
Before Overflow Fix

Copy link

vercel bot commented Jan 6, 2024

@MohammedAslam106 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@FleetAdmiralJakob
Copy link

Hey, you switched the image order: the second one is the before and the first the after image

@MohammedAslam106
Copy link
Author

Hey, you switched the image order: the second one is the before and the first the after image

Thank you, now it's in the right order.

@FleetAdmiralJakob
Copy link

You reverted all changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cards can't handle very long words
2 participants