Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(5/n) shadcn: migrate all components and blocks #6567

Merged
merged 32 commits into from
Feb 4, 2025
Merged

Conversation

shadcn
Copy link
Collaborator

@shadcn shadcn commented Feb 4, 2025

This PR:

  • migrates all components and blocks to Tailwind v4
  • upgrades to React 19 i.e no more forwardRef
  • simplifies the TypeScript types
  • adds data-slot attributes to all primitives
  • adds *Icon suffix to all lucide-react imports

The v4 upgrade is done in a separate workspace but builds to apps/www/public/r/styles/new-york-v4. This allows us to detect Tailwind v4 in the cli and hotswap the registry url.

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 8:10pm

@M0HAMEDHANY
Copy link

#6538
@shadcn

if you are facing issue because of tailwind priority classes try to put the sm:max-w-md in this order :

"fixed left-[50%] top-[50%] z-50 grid w-full max-w-[calc(100%-2rem)] translate-x-[-50%] translate-y-[-50%] gap-4 border bg-background p-6 shadow-lg duration-200 data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[state=closed]:slide-out-to-left-1/2 data-[state=closed]:slide-out-to-top-[48%] data-[state=open]:slide-in-from-left-1/2 data-[state=open]:slide-in-from-top-[48%] sm:max-w-md sm:rounded-lg"

@shadcn shadcn merged commit e516481 into main Feb 4, 2025
6 checks passed
@shadcn shadcn deleted the shadcn/05-tailwind-v4 branch February 4, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants