Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix for column grouping #945

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

Lantianyou
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 7:10pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-template ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2023 7:10pm

@vercel
Copy link

vercel bot commented Jul 17, 2023

@Lantianyou is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@Lantianyou
Copy link
Contributor Author

According to docs from tanstack table, adding colSpan here at column header can make the style of grouped column more accurate.

image

@Lantianyou
Copy link
Contributor Author

The comparison between toggle the parameter on and off:
image

image

You can try the result here at line 117 https://codesandbox.io/p/sandbox/github/tanstack/table/tree/main/examples/react/column-groups?embed=1

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@kodiakhq kodiakhq bot merged commit 08018ed into shadcn-ui:main Nov 12, 2023
6 checks passed
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants