Support shader-printf and remove write-only texture WAR #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
approved these changes
Oct 31, 2024
| interface IPrintf | ||
| { | ||
| uint32_t typeFlag(); | ||
| uint32_t writePrintfWords(); |
There was a problem hiding this comment.
If we pass the index counter + g_printBuffer directly into this method, we can make vectors and matrices or even arrays implement IPrintf.
There was a problem hiding this comment.
yea, good point, but now we can not add g_printBuffer into the function parameter. Looks like wgsl doesn't support it and we need some legalization path like glsl to make this happen.
|
|
||
| internal RWStructuredBuffer<FormatedStruct> g_printedBuffer; | ||
|
|
||
| interface IPrintf |
There was a problem hiding this comment.
public interface IPrintable.
csyonghe
reviewed
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shader-printf support in our playground, now user can play with c style printf.
Since slang already support write-only texture type, we can now remove the WAR that using one-channel write-read texture as the storage texture and encode all color channels into one. Now we can use 4 channel texture in our playground.
TODO:
There are still two remaining issues on slang side.