Refactor the code for synthesizing the body of constructor #5231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizhangNV
force-pushed
the
refactor_fill_body
branch
from
cdc4103
to
d21db8e
Compare
kaizhangNV
force-pushed
the
refactor_fill_body
branch
from
d21db8e
to
a759318
Compare
kaizhangNV
changed the title
csyonghe
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a separate PR for the issue #5192.
The only reason we separate this from PR #5215 is we don't want to bloat the size this PR.
This change just refactor the logic of synthesizing the body of the constructor inside
SemanticsDeclBodyVisitor::visitAggTypeDecl.It makes the code more manageable and readable, and also remove some redundant logic and variable creation.