Add rurban's upgrades #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`matchplus` can be simplified by only modifying `matchlength` once the complete match is successful. This means it doesn't have to rewind `matchlength` as it iterates through each possible `matchpattern`. This also means it keeps `matchlength` unmodified if it doesn't return a match. Because of this last part, this also means that `matchstar` can leverage `matchplus` which reduces it to single line of code `return matchplus(...) || matchpattern(..)`.
so far we store the groups as strings, but we really should compile them into independent regex_t.
similar to matchquestion, just that empty branches match an empty text also.
extra ok and nok regex testcase files for easier python cross-tests. also less confusing quotings.
n == 0 is invalid. m must be >= n.
match at least n times
match max. m times
whitespace and move the output to the tests. only a single-line seperator.
invalid quantifiers must fail.
extend test_compile.
Note that invalid quantifiers patterns such as '{2}'
need to match exact.
as in python and perl
now all cases
storing only the len of group patterns. add internal DEBUG support.
length of nested groups
invalid \xXX sequences are matched asis. No error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.