Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Restructure release workflow #60

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

joeyparrish
Copy link
Member

This isolates elevated permissions to the release publication job only, and simplifies a more complex sequence of creating a draft release, then building and attaching binaries, then compiling release notes, then publishing the release. Now we simply build, compile notes, then publish a full release with notes and binaries at once.

This also removes the need for our own "api client" in JavaScript. Now we perform these actions with GitHub's own tools: "gh" command line to create the release and "actions/" official actions to upload and download build artifacts.

This isolates elevated permissions to the release publication job only, and simplifies a more complex sequence of creating a draft release, then building and attaching binaries, then compiling release notes, then publishing the release.  Now we simply build, compile notes, then publish a full release with notes and binaries at once.

This also removes the need for our own "api client" in JavaScript.  Now we perform these actions with GitHub's own tools: "gh" command line to create the release and "actions/" official actions to upload and download build artifacts.
@joeyparrish
Copy link
Member Author

Validated with a full release on my fork.

@joeyparrish joeyparrish merged commit a1a0263 into shaka-project:main Dec 18, 2024
11 checks passed
@joeyparrish joeyparrish deleted the restructure-release branch December 18, 2024 16:21
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Feb 16, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants