Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Switch pull_request_target to pull_request #66

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

joeyparrish
Copy link
Member

With this change, GitHub will start to enforce "require approval" settings for the repo, which pull_request_target allows PR authors to get around.

To stop using pull_request_target, we also have to stop using vars, which are not available on pull_request triggers. Instead, we use the "environments" trick used by Shaka Packager's workflows before vars was introduced to GitHub Actions. This is a safer system.

@joeyparrish joeyparrish requested review from theodab and a team January 17, 2025 21:12
With this change, GitHub will start to enforce "require approval" settings for the repo, which `pull_request_target` allows PR authors to get around.

To stop using `pull_request_target`, we also have to stop using `vars`, which are not available on `pull_request` triggers.  Instead, we use the "environments" trick used by Shaka Packager's workflows before `vars` was introduced to GitHub Actions.  This is a safer system.
@joeyparrish joeyparrish merged commit e707575 into shaka-project:main Jan 17, 2025
12 checks passed
@joeyparrish joeyparrish deleted the pull-request branch January 17, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants