ci: Switch pull_request_target to pull_request #66
+94
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, GitHub will start to enforce "require approval" settings for the repo, which
pull_request_target
allows PR authors to get around.To stop using
pull_request_target
, we also have to stop usingvars
, which are not available onpull_request
triggers. Instead, we use the "environments" trick used by Shaka Packager's workflows beforevars
was introduced to GitHub Actions. This is a safer system.