Skip to content

Commit

Permalink
Merge pull request #169 from shakedzy/167-when-using-the-associations…
Browse files Browse the repository at this point in the history
…-in-a-notebook-and-plot=false-the-plot-gets-closed-ie-removed-without-ever-being-shown

fix for #167 #168
  • Loading branch information
shakedzy authored Jan 6, 2025
2 parents fbf525d + 932ddda commit 152c3db
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Change Log

## 0.7.9
* Fixing `nominal.associations(plot=False)` not working as expected on Jupyter-based notebooks (issues [#167](https://github.com/shakedzy/dython/issues/167) & [#168](https://github.com/shakedzy/dython/issues/168))

## 0.7.8
* `nominal.associations` now attempts to set the figure-size automatically based on output (issue [#30](https://github.com/shakedzy/dython/issues/30), by **[@Swish78](https://github.com/Swish78)**)

Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.7.8
0.7.9
4 changes: 3 additions & 1 deletion dython/_private.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ def plot_or_not(plot: bool) -> None:
if plot:
plt.show()
elif not plot and IS_JUPYTER:
plt.close()
fig = plt.gcf()
if fig:
plt.close(fig)


def convert(
Expand Down

0 comments on commit 152c3db

Please sign in to comment.