-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.1.0 #33
Open
shalecraig
wants to merge
77
commits into
master
Choose a base branch
from
1.1.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Version 1.1.0 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: determine how to indent TODO lists on github. |
There's gotta be a better way to do this, but #yolo...
TODO: why didn't the prev one work?
Next is the makefile :D
Added tests that were somehow missed in transition
Shale/1.1.0/remove lockfile
Makefile now has more Flags, more PHONY
Next up: adding explicit sizing
Updated tests accordingly.
Accel: - accel_start_record_gesture takes a uint16_t *gesture - accel_end_record_gesture takes a uint16_t *gesture Moving_avg: - wbuf_len is now a uint16_t Updated pebble sample accordingly
-Wincompatible-pointer-types -Wtype-limits -Werror=type-limits
Shale/1.1.0/makefile pedantic++
- accel_callback takes a uint16_t gesture_id - accel_callback takes a uint32_t offset_found
- allocate_moving_avg takes an uint16_t subtotal_sizes - Created a "data type" for the type stored in the moving_avg
Shale/1.1.0/finish changing types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's it. See milestone V1.1.0
grep -Ir --exclude=".*(\.git|node_modules)" TODO * | wc -l == 21
, let's fix it)accel_reset_affinities_for_gesture
int
andlong
.Stretch goal: