WIP: Implement CoAP over TCP #177
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #177 +/- ##
==========================================
- Coverage 29.91% 27.20% -2.72%
==========================================
Files 62 65 +3
Lines 2811 3084 +273
==========================================
- Hits 841 839 -2
- Misses 1970 2245 +275
☔ View full report in Codecov by Sentry. |
|
I now actually managed to finish the basic logic for connecting and communicating with a server. There is still some more polish required, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in some other PR, I started working on improving the CoAP over TCP implementation, adding the necessary logic for exchanging messages. Connecting to a (plain) TCP server and sending and receiving messages already works.
However, responses cannot be matched to requests yet, since the matching logic has to be slightly adjusted (CoAP over TCP messages don't contain message ID or type fields). Furthermore, the layer stack needs to take into account that resending messages isn't needed for reliable transport. The implementation is also lacking support for signaling messages, which need to be sent at the beginning of an exchange. Lastly, I currently perform three stream transformations in a row for incoming TCP segments, which could probably improved efficiency-wise.
So there is still plenty to do, which I hope to deal with over the next couple of weeks.