Refactor connection handling and add support for WebSocket #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can't pull dart.io(or dart.html) into mqtt5_client, this has to be platform neutral. These libs are pulled into the specialized browser/server clients which extend MqttClient. The mqtt_client package already has a solution to this issue, I just need to reflect it here. |
Seems reasonable, I will wait for your solution. If you think it is better to close the PR do as you think best! |
|
OK will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111
This commit refactors the connection handling in the
mqtt_connection_base.dartfile. It introduces support for WebSocket connections by importing thedart:iolibrary. The_disconnect()method has been modified to close the client properly based on its type. If the client is a WebSocket, it is closed using theclose()method. If it is a Socket, it is destroyed using thedestroy()method. For other types of clients, thedestroy()method is called. This change improves the overall connection handling in the MQTT client.