Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle exceptions on prometheus operations #28

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

xhdnoah
Copy link

@xhdnoah xhdnoah commented Feb 14, 2025

Prometheus 监控数据的操作属于辅助功能,如果出错(Prometheus 文件找不到等)不应该影响到 cache 数据获取,因此在两处操作指标数据的地方增加捕获并忽略的逻辑

@coveralls
Copy link

coveralls commented Feb 14, 2025

Pull Request Test Coverage Report for Build 13325520793

Details

  • 5 of 9 (55.56%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 96.01%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cachext/cache.py 4 8 50.0%
Totals Coverage Status
Change from base Build 9028295268: -1.0%
Covered Lines: 385
Relevant Lines: 401

💛 - Coveralls

@xhdnoah xhdnoah force-pushed the fix/cache-monitor branch 3 times, most recently from 7f29413 to f8c6e28 Compare February 14, 2025 08:37
@nicholasxuu nicholasxuu merged commit e9ca7e3 into shanbay:master Feb 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants