Fixed some bug #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanzi
requested changes
Dec 25, 2016
| @@ -40,16 +34,36 @@ func watch(path string, abort <-chan struct{}) (<-chan string, error) { | |||
| info, err := os.Stat(fp.Name) | |||
| if err == nil && info.IsDir() { | |||
| // Add newly created sub directories to watch list | |||
| log.Printf("Add newly diectory ( %s )\n", fp.Name) | |||
|
|
||
| if os.IsNotExist(err) { | ||
| log.Printf("Dictory (%s) have been removed\n", fp) | ||
| log.Println("here=======here") |
|
|
||
| haveDir := false | ||
| for _, fileinfo := range fileInfos { | ||
| if fileinfo.IsDir() == true && fileinfo.Name() != "." && fileinfo.Name() != ".git" { |
There was a problem hiding this comment.
感觉作为一个简单的 utility 直接 ignore 掉 .git 并不好。
我觉得在使用过程中指定需要侦听的文件类型就应该够用了。对于 .git 这种需求可以做一个选项出来。直接 hard code 不好。
There was a problem hiding this comment.
您之前的方案，会把.git下的文件全部都监控起来，我真的不明白监控.git文件有什么特殊的用意。
| "log" | ||
| "os" | ||
| "os/signal" | ||
| "path/filepath" | ||
| // "wu/command" |
|
|
||
| // Run the command once at initially | ||
| r.command.Start(200 * time.Millisecond) | ||
| haveBuild := false | ||
| r.command.Start(200*time.Millisecond, haveBuild) |
There was a problem hiding this comment.
目前的提示就是done 但是我想合理的提示应该是编译成功一次之后 之后就是重新启动了 你觉得呢
| continue | ||
| } | ||
|
|
||
| if filepath.Ext(fileinfo.Name()) == ".go" { |
There was a problem hiding this comment.
hmmm 这里 hardcode 了 go ,如果想要讲 wu 用在其他地方就没办法了吧。这么做有什么理由么？
There was a problem hiding this comment.
wu 按照我的理解新的逻辑只会侦听有 Go 源文件存在的目录，也不会在新建文件和文件夹出现的时候自动加入侦听。这和以前的逻辑偏差太大。恐怕不能接受
There was a problem hiding this comment.
是不是做成配置的形式就可以接受了呢，另外监控go文件应该是合理的，如果想要监控其他的类型，比如html这就需要把这部分从配置里读取出来了。
新建文件夹会加入监听的啊。后半部分你讲的我不是太明白
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1: 修复了删除文件空指针错误的问题
2:增加了监控目录提示
3: 改善了启动和再次启动的提示代码
4:修复了文件改变之后但是终端会提示提示两次的问题
5: 移除了部分代码
6：过滤.git文件（噪音文件）
7: 新增readAppDirectories，获取需要监控的目录