[WIP ]VR agent #44
Open
[WIP ]VR agent #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On first startup, the management server instantiates and saves random ssh keys in the database by calling a `trim()` on the string data. On latest CentOS7 release (CentOS Linux release 7.6.1810 (Core)) I could reproduce the issue where router_proxy (ssh) did not fail and kept prompting for passphrase. By adding a newline to the id_rsa.cloud private key it did not prompt the same. This patch fixes the issue by adding a newline at the end of the generated SSH public/private keys in the DB. SSH packages details: libssh2.x86_64 1.4.3-12.el7_6.2 @updates openssh.x86_64 7.4p1-16.el7 @anaconda openssh-askpass.x86_64 7.4p1-16.el7 @base openssh-clients.x86_64 7.4p1-16.el7 @anaconda openssh-server.x86_64 7.4p1-16.el7 @anaconda Signed-off-by: Rohit Yadav <[email protected]>
Signed-off-by: Rohit Yadav <[email protected]>
Signed-off-by: Rohit Yadav <[email protected]>
Signed-off-by: Rohit Yadav <[email protected]>
Signed-off-by: Rohit Yadav <[email protected]>
Signed-off-by: Rohit Yadav <[email protected]>
8 tasks
|
cc @anuragaw |
|
Hi @dependabot[bot], your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRPC based VR/appliance agent:
Go based VR agent, cloudstack (java based client)
PoC API:
Protocol Buffers CLI:
https://github.com/ktr0731/evans