feat: wrap all utxo xpub methods in MaybeRpcResponse<T>

shapeshift · Sep 19, 2023 · 0b776a6 · 0b776a6
1 parent 5637f03
commit 0b776a6
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/packages/adapter/src/utxo/bitcoincash/bitcoincash.ts b/packages/adapter/src/utxo/bitcoincash/bitcoincash.ts
@@ -1,9 +1,9 @@
-import type { PublicKey } from '@shapeshiftoss/hdwallet-core'
 import type {
   BitcoinCashBroadcastTransactionAdapterParams,
   BitcoinCashBroadcastTransactionResponse,
   BitcoinCashGetAddressAdapterParams,
   BitcoinCashGetAddressResponse,
+  BitcoinCashGetPublicKeysResponse,
   BitcoinCashSignTransactionAdapterParams,
   BitcoinCashSignTransactionResponse,
 } from '@shapeshiftoss/metamask-snaps-types'
@@ -35,7 +35,7 @@ export const BCHGetAddress = async (
 
 export const BCHGetPublicKeys = async (
   params: BitcoinCashGetAddressAdapterParams,
-): Promise<(PublicKey | null)[]> => {
+): Promise<BitcoinCashGetPublicKeysResponse> => {
   const { addressParams, snapId } = params
   try {
     return await sendFlaskRPCRequest(

diff --git a/packages/adapter/src/utxo/dogecoin/dogecoin.ts b/packages/adapter/src/utxo/dogecoin/dogecoin.ts
@@ -1,9 +1,9 @@
-import type { PublicKey } from '@shapeshiftoss/hdwallet-core'
 import type {
   DogecoinBroadcastTransactionAdapterParams,
   DogecoinBroadcastTransactionResponse,
   DogecoinGetAddressAdapterParams,
   DogecoinGetAddressResponse,
+  DogecoinGetPublicKeysResponse,
   DogecoinSignTransactionAdapterParams,
   DogecoinSignTransactionResponse,
 } from '@shapeshiftoss/metamask-snaps-types'
@@ -33,7 +33,7 @@ export const dogecoinGetAddress = async (
 
 export const dogecoinGetPublicKeys = async (
   params: DogecoinGetAddressAdapterParams,
-): Promise<(PublicKey | null)[]> => {
+): Promise<DogecoinGetPublicKeysResponse> => {
   const { addressParams, snapId } = params
   try {
     return await sendFlaskRPCRequest(

diff --git a/packages/adapter/src/utxo/litecoin/litecoin.ts b/packages/adapter/src/utxo/litecoin/litecoin.ts
@@ -1,9 +1,9 @@
-import type { PublicKey } from '@shapeshiftoss/hdwallet-core'
 import type {
   LitecoinBroadcastTransactionAdapterParams,
   LitecoinBroadcastTransactionResponse,
   LitecoinGetAddressAdapterParams,
   LitecoinGetAddressResponse,
+  LitecoinGetPublicKeysResponse,
   LitecoinSignTransactionAdapterParams,
   LitecoinSignTransactionResponse,
 } from '@shapeshiftoss/metamask-snaps-types'
@@ -33,7 +33,7 @@ export const LTCGetAddress = async (
 
 export const LTCGetPublicKeys = async (
   params: LitecoinGetAddressAdapterParams,
-): Promise<(PublicKey | null)[]> => {
+): Promise<LitecoinGetPublicKeysResponse> => {
   const { addressParams, snapId } = params
   try {
     return await sendFlaskRPCRequest(

diff --git a/packages/types/src/snap.ts b/packages/types/src/snap.ts
@@ -234,6 +234,9 @@ export type BinanceGetAddressResponse = MaybeRpcResponse<BinanceAddress>
 export type BitcoinCashGetAddressResponse = MaybeRpcResponse<BitcoinCashAddress>
 export type BitcoinGetAddressResponse = MaybeRpcResponse<BitcoinAddress>
 export type BitcoinGetPublicKeysResponse = MaybeRpcResponse<PublicKeys>
+export type BitcoinCashGetPublicKeysResponse = MaybeRpcResponse<PublicKeys>
+export type DogecoinGetPublicKeysResponse = MaybeRpcResponse<PublicKeys>
+export type LitecoinGetPublicKeysResponse = MaybeRpcResponse<PublicKeys>
 export type CosmosGetAddressResponse = MaybeRpcResponse<CosmosAddress>
 export type DogecoinGetAddressResponse = MaybeRpcResponse<DogecoinAddress>
 export type EthereumGetAddressResponse = MaybeRpcResponse<EthereumAddress>