feat: make snaps build and run #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7072fe67bfd7a2710ce4a7b792b571943f5e5639.
This was referenced Aug 26, 2023
gomesalexandre
force-pushed
the
make-it-run
branch
from
b78c23a
to
d75641f
Compare
kaladinlight
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes snaps happy and ready to be consumed in web.
Alphas are now published to npm for all packages under
1.0.0-alpha.11and are matching the current state of the repo:https://www.npmjs.com/package/@shapeshiftoss/metamask-snaps
https://www.npmjs.com/package/@shapeshiftoss/metamask-snaps-types
https://www.npmjs.com/package/@shapeshiftoss/metamask-snaps-adapter
Hence disregard the description below.
Opening draft to visualize the diffNote, both #100, shapeshift/hdwallet#628, and shapeshift/web#5166 assume verdaccio running on default port 4873, and all packages published there:This is only for development purposes, and config should be reverted to default uplink before merging each of these PRs.