Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unrug RUNE in MM snaps #7724

Merged
merged 5 commits into from
Sep 10, 2024
Merged

feat: unrug RUNE in MM snaps #7724

merged 5 commits into from
Sep 10, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Sep 10, 2024

Description

Does what it says on the box. Note: This currently assumes you've uninstalled the snap and reinstalled it.

Migration plan TBD in

Issue (if applicable)

closes #7713

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low

Testing

  • Uninstall the snap if currently installed
  • Reinstall the snap and ensure it's on v.1.0.9 (see screenshots)
  • Ensure RUNE Txs are happy across the app (sends, RUNEPool, LP)

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

  • Sends
Screenshot 2024-09-10 at 21 40 39 Screenshot 2024-09-10 at 21 40 39 Screenshot 2024-09-10 at 21 41 47 Screenshot 2024-09-10 at 21 41 56
  • RUNEPool
image
  • LP
image

@gomesalexandre gomesalexandre changed the title feat: unrug RUNE in MM snaps wip: unrug RUNE in MM snaps Sep 10, 2024
@gomesalexandre gomesalexandre changed the title wip: unrug RUNE in MM snaps feat: unrug RUNE in MM snaps Sep 10, 2024
@gomesalexandre gomesalexandre marked this pull request as ready for review September 10, 2024 20:15
@gomesalexandre gomesalexandre requested a review from a team as a code owner September 10, 2024 20:15
@kaladinlight
Copy link
Contributor

image
image
image
image

@gomesalexandre gomesalexandre merged commit 777bf90 into develop Sep 10, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the feat_unrug_snaps branch September 10, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MM Snaps version bump post TC hardfork
2 participants