Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new mobile wallet drawer import flow #8810

Merged
merged 6 commits into from
Feb 13, 2025

Conversation

NeOMakinG
Copy link
Collaborator

@NeOMakinG NeOMakinG commented Feb 12, 2025

Description

  • Import flow within the new mobile wallet dialog
  • Fixes the fact that you can't go back from create wallet
  • Fixes a few onboarding modal issues (this should be full width soon with the mobile polish)

Issue (if applicable)

closes #8794

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Mobile app only:

  • Try to open create wallet and import from the mobile home then go back
  • Try go create a wallet from mobile home, should work as usually
  • Try to import a wallet from mobile home, should work as usually
  • Try to click on create a wallet and go back (from the already connected view)
  • Try to click on import a wallet and go back (from the already connected view)
  • Try to create a wallet by being connected to another wallet already, should work
  • Try to import a wallet by being connected to another wallet already, should work

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

https://jam.dev/c/d7fe265e-f6a7-4386-9f1f-2f81e54ca092

@NeOMakinG NeOMakinG marked this pull request as ready for review February 12, 2025 18:01
@NeOMakinG NeOMakinG requested a review from a team as a code owner February 12, 2025 18:01
@NeOMakinG NeOMakinG force-pushed the mobile-import-drawer branch from 7f33a00 to edd8fcb Compare February 12, 2025 18:01
@gomesalexandre gomesalexandre self-requested a review February 13, 2025 20:22
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually looks sane to me - runtime pass incoming!

Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gomesalexandre gomesalexandre enabled auto-merge (squash) February 13, 2025 22:06
@gomesalexandre gomesalexandre merged commit 170a733 into develop Feb 13, 2025
3 checks passed
@gomesalexandre gomesalexandre deleted the mobile-import-drawer branch February 13, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add import wallet inside the new mobile drawer
2 participants