Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated example to null-safety and new lib versions #208

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LuisMiguelMP
Copy link

Updated the example to:

  • match the lib sdk version;
  • new lib versions and minor changes, like image and image_picker.
    Also implemented null-safety.

I appreciate your feedback and suggestions :)

@Bsm-B
Copy link

Bsm-B commented Aug 2, 2021

@LuisMiguelMP Thanks it worked great

@RuotongX
Copy link

Thank you very much! That works great

@Puspharaj
Copy link

please add this is to support v2 embedding

package io.flutter.plugins.firebasecoreexample;

import io.flutter.embedding.android.FlutterActivity;
import io.flutter.embedding.engine.FlutterEngine;
import io.flutter.plugins.firebase.core.FirebaseCorePlugin;

public class MainActivity extends FlutterActivity {
  // You can keep this empty class or remove it. Plugins on the new embedding
  // now automatically registers plugins.
}

@rafay-tariq
Copy link

please add this is to support v2 embedding

package io.flutter.plugins.firebasecoreexample;

import io.flutter.embedding.android.FlutterActivity;
import io.flutter.embedding.engine.FlutterEngine;
import io.flutter.plugins.firebase.core.FirebaseCorePlugin;

public class MainActivity extends FlutterActivity {
  // You can keep this empty class or remove it. Plugins on the new embedding
  // now automatically registers plugins.
}

can you please tell me where to add these lines ? @Puspharaj

@Puspharaj
Copy link

Puspharaj commented Oct 29, 2021 via email

@LuisMiguelMP
Copy link
Author

Sure just give some time, Will do PR and test then push it soon.

On Fri, Oct 29, 2021, 18:34 Luís Miguel Massih Pereira < @.***> wrote: Nice @Puspharaj https://github.com/Puspharaj! Can you include the v2 embedding support into the 'LuisMiguelMP:master' and I update this PR with that? Thank you and have a good weekend. :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#208 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDOL55AHH7BVQUCW6IRLIDUJKLXHANCNFSM45LJMMEA .

Nice, thank you very much! =)

@rafay-tariq
Copy link

is there any update on this issue. waiting to be done.

@Puspharaj
Copy link

Puspharaj commented Nov 1, 2021 via email

@Puspharaj
Copy link

Pushed some significant changes to the repo, Because lot of things has changed since this plugin development. Hope Luis will commit the changes to master and tlite version 1.1.3 is available soon

@rafay-tariq
Copy link

Thanks @Puspharaj . Will check this commit soon

Puspharaj and others added 2 commits November 4, 2021 10:12
Android V2 Embedding changes done, Further Web under process.
@LuisMiguelMP
Copy link
Author

LuisMiguelMP commented Nov 5, 2021

Hello =),

I merged the @Puspharaj changes. Thank you very much!

@shaqian could you please check it?

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants