Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to RN0.60 #13

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update to RN0.60 #13

wants to merge 7 commits into from

Conversation

kaelhem
Copy link

@kaelhem kaelhem commented Sep 13, 2019

Hello,
Thanks a lot for your library, it's awesome !

In this pull request I did several small things to make it compatible with the last version of react native. Here is a comprehensive list of what I did :

  • updated TensorFlowLite dependency to 1.13.1
  • updated / moved Podspec file
  • move example project to a new generated one (in order to have the last RN templates)
  • updated README to reflect these changes
  • bump package.json version to 0.0.6

With these changes, I was able to successfully build the example app on both iOS & Android on react-native 0.65 !

Let me know if you have questions / remarks.

@ghost
Copy link

ghost commented Sep 13, 2019

Is it possible to change the Podfile dependency from "TensorFlowLite" to "TensorFlowLiteObjC". The former library is a bit outdated and doesn't support models created in newer version of TFlite

You can find some documentation on it here: https://github.com/tensorflow/tensorflow/tree/master/tensorflow/lite/experimental/objc

@kaelhem
Copy link
Author

kaelhem commented Sep 15, 2019

In fact, I tried to update to TensorFlowLiteObjC v1.14.0, but the library is very different and the documentation very poor. I suppose that an obj-c/swift developer could do something to make it work...

@shaqian
Copy link
Owner

shaqian commented Oct 5, 2019

Hi kaelhem,

Thanks a lot for making the library work with RN0.60!

Would these changes break RN < 0.60?

Thanks,
Qian

@kaelhem
Copy link
Author

kaelhem commented Oct 8, 2019

Hi shaqian,
With RN 0.60, iOS projects uses cocoapods and android ones are based on AndroidX. Because of that, project templates are quite different, so yes, I suppose these changes will break with RN <0.60.

Cheers,
kaelhem

@rafaelcavalcante
Copy link

Any updates on this?

@kaelhem
Copy link
Author

kaelhem commented Sep 18, 2020

not on my side... I moved on, sorry.

@TuJobs
Copy link

TuJobs commented Mar 31, 2021

Why isn't the library updated, can we annotate the library version with react-native version?

@utkarsh867
Copy link

@shaqian Hoping that we can move the package on to RN 0.60 and later using this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants