Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump assets/syntaxes/01_Packages from 759d6ee to 5f6d4cf #2460

Closed
wants to merge 1 commit into from

Conversation

WhyNotHugo
Copy link

@WhyNotHugo
Copy link
Author

Huh, hang on, this is not working as I expected. Even though 5f6d4cf003d29c3c2c8169441ac1f9de8035d387 is in that range, the changes in there are not applying as expected.

@WhyNotHugo
Copy link
Author

Yeah, actually, I think I didn't run bash assets/create.sh with the right version and my testing is bogus.

@WhyNotHugo WhyNotHugo marked this pull request as draft January 28, 2023 17:34
@keith-hall
Copy link
Collaborator

Please note that upgrading the Packages repo is not possible at this time because our syntax highlighting library doesn't support it yet (see #2358 (comment)). If you have some commits you wish to apply to bat, the only real option at the moment is to create a patch file in this repo I believe...

@keith-hall keith-hall added the syntect-features-required Blocked by lack of support in syntect label Feb 10, 2023
@Enselic
Copy link
Collaborator

Enselic commented Mar 4, 2023

Let's close this PR for now to keep the PR inbox clean.

@Enselic Enselic closed this Mar 4, 2023
@WhyNotHugo WhyNotHugo deleted the update-packages branch March 5, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
syntect-features-required Blocked by lack of support in syntect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants