Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] fix cargo audit failing to run successfully #3154

Merged
merged 5 commits into from
Dec 30, 2024
Merged

[CI] fix cargo audit failing to run successfully #3154

merged 5 commits into from
Dec 30, 2024

Conversation

keith-hall
Copy link
Collaborator

@keith-hall keith-hall commented Dec 26, 2024 •
edited
Loading

  • cargo audit failed to run in CI, presumably the ubuntu-latest image version changed and no longer has the cargo-audit crate installed by default
  • audit failed due to unsoundness in anstream
  • upgrading clap to fix that required bumping MSRV from 1.70 to 1.74, released over a year ago

@keith-hall keith-hall changed the title [CI] fix cargo audit failing to run [CI] fix cargo audit failing to run successfully Dec 26, 2024
Bump MSRV to 1.74
d660cca 
released over a year ago
@keith-hall
Copy link
Collaborator Author

keith-hall commented Dec 26, 2024 •
edited
Loading

okay, looks like we will need syntect to move away from yaml-rust trishume/syntect#555 trishume/syntect#544

Keith Hall added 2 commits December 30, 2024 20:53
Enselic
Enselic approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@Enselic Enselic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@keith-hall keith-hall merged commit 8a9821f into master Dec 30, 2024
24 checks passed
@keith-hall keith-hall deleted the fix_cargo_audit_ci branch December 30, 2024 19:26
@keith-hall keith-hall mentioned this pull request Dec 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enselic Enselic Enselic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keith-hall @Enselic