[VL] Minor follow-ups for apache#6942 (apache#7129)

sharkdtu · Oct 14, 2024 · 523501a · 523501a
1 parent 01d2f80
commit 523501a
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 22 deletions.
diff --git a/backends-velox/pom.xml b/backends-velox/pom.xml
@@ -187,7 +187,7 @@
     <resources>
       <resource>
         <directory>${cpp.releases.dir}</directory>
-        <targetPath>org/apache/gluten/${platform}/${arch}</targetPath>
+        <targetPath>${platform}/${arch}</targetPath>
       </resource>
       <resource>
         <directory>${resource.dir}</directory>

diff --git a/backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxListenerApi.scala b/backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxListenerApi.scala
@@ -138,8 +138,8 @@ class VeloxListenerApi extends ListenerApi with Logging {
       JniLibLoader.loadFromPath(libPath, false)
     } else {
       val baseLibName = conf.get(GlutenConfig.GLUTEN_LIB_NAME, "gluten")
-      loader.load(s"$baseLibPackage/${System.mapLibraryName(baseLibName)}", false)
-      loader.load(s"$baseLibPackage/${System.mapLibraryName(VeloxBackend.BACKEND_NAME)}", false)
+      loader.load(s"$platformLibDir/${System.mapLibraryName(baseLibName)}", false)
+      loader.load(s"$platformLibDir/${System.mapLibraryName(VeloxBackend.BACKEND_NAME)}", false)
     }
 
     // Initial native backend with configurations.
@@ -152,18 +152,6 @@ class VeloxListenerApi extends ListenerApi with Logging {
     GlutenRowSplitter.setInstance(new VeloxRowSplitter())
   }
 
-  private lazy val baseLibPackage: String = {
-    val osName = System.getProperty("os.name") match {
-      case n if n.contains("Linux") => "linux"
-      case n if n.contains("Mac") => "darwin"
-      case _ =>
-        // Default to linux
-        "linux"
-    }
-    val arch = System.getProperty("os.arch")
-    s"org/apache/gluten/$osName/$arch"
-  }
-
   private def shutdown(): Unit = {
     // TODO shutdown implementation in velox to release resources
   }
@@ -174,6 +162,17 @@ object VeloxListenerApi {
   //  As spark conf may change when active Spark session is recreated.
   private val driverInitialized: AtomicBoolean = new AtomicBoolean(false)
   private val executorInitialized: AtomicBoolean = new AtomicBoolean(false)
+  private val platformLibDir: String = {
+    val osName = System.getProperty("os.name") match {
+      case n if n.contains("Linux") => "linux"
+      case n if n.contains("Mac") => "darwin"
+      case _ =>
+        // Default to linux
+        "linux"
+    }
+    val arch = System.getProperty("os.arch")
+    s"$osName/$arch"
+  }
 
   private def inLocalMode(conf: SparkConf): Boolean = {
     SparkResourceUtil.isLocalMaster(conf)

diff --git a/package/pom.xml b/package/pom.xml
@@ -98,7 +98,7 @@
       <dependencies>
         <dependency>
           <groupId>org.apache.gluten</groupId>
-	  <artifactId>gluten-delta</artifactId>
+          <artifactId>gluten-delta</artifactId>
           <version>${project.version}</version>
         </dependency>
       </dependencies>
@@ -196,12 +196,12 @@
                   <excludes>
                     <exclude>META-INF/*.SF</exclude>
                     <exclude>META-INF/*.DSA</exclude>
-		    <exclude>META-INF/*.RSA</exclude>
-		    <exclude>META-INF/DEPENDENCIES</exclude>
-		    <exclude>META-INF/LICENSE.txt</exclude>
-		    <exclude>META-INF/NOTICE.txt</exclude>
-		    <exclude>LICENSE.txt</exclude>
-	            <exclude>NOTICE.txt</exclude>
+                    <exclude>META-INF/*.RSA</exclude>
+                    <exclude>META-INF/DEPENDENCIES</exclude>
+                    <exclude>META-INF/LICENSE.txt</exclude>
+                    <exclude>META-INF/NOTICE.txt</exclude>
+                    <exclude>LICENSE.txt</exclude>
+                    <exclude>NOTICE.txt</exclude>
                   </excludes>
                 </filter>
               </filters>