[WIP] [feature] add binder design #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Tangruilin PTAL. |
fansehep
commented
Oct 3, 2023
Comment on lines
+30
to
+36
| pub fn bind_stmt(&mut self, stmt: Statement) -> Result<LogicalPlan> { | ||
| match stmt { | ||
| Statement::CreateTable(create_stmt) => self.bind_create_stmt(create_stmt), | ||
| Statement::Select(select_stmt) => self.bind_select_stmt(select_stmt), | ||
| _ => Err(Error::BinderErr(fmt_err!("not impl statement"))), | ||
| } | ||
| } |
There was a problem hiding this comment.
这里看起来需要加入一个 BindContext 信息, 如果我们要做成 CS 模型, 需要携带上 Server 与 Client 上的一些会话信息, 例如在一个 ReadOnlyTxn, 或者其他的什么操作.
|
@fansehep 这个 PR 后面交给我来接手吧 |
@Tangruilin 看起来不错, 交给你啦 ❤️ |
Signed-off-by: fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR solve? (这个 PR 解决了什么问题)
#29
Retionable for this PR Change (这个 PR 做了什么改变)