perf(parser): remove the return value option #47
Conversation
apengn
force-pushed
the
remove_parse_expression_return_opton
branch
2 times, most recently
from
f603f4b
to
3ef84f9
Compare
| @@ -460,7 +460,7 @@ impl Parser { | |||
|
|
|||
| loop { | |||
| self.next_token(); | |||
| exprs.push(self.parse_expression(Precedence::Lowest)?); | |||
| exprs.push(Some(self.parse_expression(Precedence::Lowest)?)); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I haven't hacked into this InsertStmt structure, although it can also remove the Option, if possible, I can change it
There was a problem hiding this comment.
I haven't hacked into this
InsertStmtstructure,although it can also remove theOption`, if possible, I can change it
Emmm, you can open an other issue to trace this question if you want to solve it. 😃
There was a problem hiding this comment.
I haven't hacked into this
InsertStmtstructure,although it can also remove theOption`, if possible, I can change itEmmm, you can open an other issue to trace this question if you want to solve it. 😃
I just saw it out of the blue and questioned it.
src/parser/mod.rs
Outdated
| Some(expr) => expr, | ||
| None => { | ||
| return Err(Error::ParseErr(fmt_err!( | ||
| "ON Predicate expression is not valid!" | ||
| ))); | ||
| } | ||
| }) | ||
| Some(self.parse_expression(Precedence::Lowest)?) |
There was a problem hiding this comment.
I think we should keep this error message here.
There was a problem hiding this comment.
I think we should keep this error message here.
And in other place. you hide the error message. May should keep them too.
src/parser/mod.rs
Outdated
| if !is_prefix_oper(&self.pre_token) { | ||
| return Err(Error::ParseErr(fmt_err!( | ||
| "No prefixOperatorFunc for: {:?}", | ||
| "No prefix Operator Func for: {}", |
apengn
force-pushed
the
remove_parse_expression_return_opton
branch
from
3ef84f9
to
b9e20de
Compare
Signed-off-by: apengn <[email protected]>
apengn
force-pushed
the
remove_parse_expression_return_opton
branch
from
b9e20de
to
bbdfca9
Compare
|
Really thanks for your contribution! @apengn ❤️ |
remove the return value option
Which issue does this PR solve? (这个 PR 解决了什么问题)
#46
Retionable for this PR Change (这个 PR 做了什么改变)
remove the return value option