Skip to content

Commit

Permalink
add issuance not found code
Browse files Browse the repository at this point in the history
  • Loading branch information
shawnxie999 committed Sep 6, 2024
1 parent 8ffbab0 commit a28a767
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 2 deletions.
1 change: 1 addition & 0 deletions include/xrpl/protocol/TER.h
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ enum TECcodes : TERUnderlyingType {
tecMPT_MAX_AMOUNT_EXCEEDED = 193,
tecMPT_LOCKED = 194,
tecMPT_NOT_SUPPORTED = 195,
tecMPT_ISSUANCE_NOT_FOUND = 196
};

//------------------------------------------------------------------------------
Expand Down
1 change: 1 addition & 0 deletions src/libxrpl/protocol/TER.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ transResults()
MAKE_ERROR(tecMPTOKEN_EXISTS, "The account already owns the MPToken object."),
MAKE_ERROR(tecMPT_MAX_AMOUNT_EXCEEDED, "The MPT's maximum amount is exceeded."),
MAKE_ERROR(tecMPT_LOCKED, "MPT is locked by the issuer."),
MAKE_ERROR(tecMPT_ISSUANCE_NOT_FOUND, "The MPTokenIssuance object is not found"),

MAKE_ERROR(tefALREADY, "The exact transaction was already in this ledger."),
MAKE_ERROR(tefBAD_ADD_AUTH, "Not authorized to add account."),
Expand Down
18 changes: 18 additions & 0 deletions src/test/app/MPToken_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -980,6 +980,24 @@ class MPToken_test : public beast::unit_test::suite
jrr[jss::result][jss::error_message] ==
"Field 'build_path' not allowed in this context.");
}

// Issuer fails trying to send fund after issuance was destroyed
{
Env env{*this, features};

MPTTester mptAlice(env, alice, {.holders = {&bob}});

mptAlice.create({.ownerCount = 1, .holderCount = 0});

mptAlice.authorize({.account = &bob});

// alice destroys issuance
mptAlice.destroy({.ownerCount = 0});

// alice tries to send bob fund after issuance is destroy, should
// fail.
mptAlice.pay(alice, bob, 100, tecMPT_ISSUANCE_NOT_FOUND);
}
}

void
Expand Down
4 changes: 2 additions & 2 deletions src/xrpld/ledger/detail/View.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1875,7 +1875,7 @@ rippleCredit(
view.update(sle);
}
else
return tecINTERNAL;
return tecMPT_ISSUANCE_NOT_FOUND;
}
else
{
Expand Down Expand Up @@ -1914,7 +1914,7 @@ rippleCredit(
return tecINSUFFICIENT_FUNDS;
}
else
return tecINTERNAL;
return tecMPT_ISSUANCE_NOT_FOUND;
}
else
{
Expand Down

0 comments on commit a28a767

Please sign in to comment.