Skip to content

Commit

Permalink
remove hadrian extra cabal flags
Browse files Browse the repository at this point in the history
  • Loading branch information
shayne-fletcher committed Jan 3, 2025
1 parent 27e2421 commit 080ef42
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ghc-lib-ghc-HEAD-ghc-9.10.1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- uses: haskell-actions/setup@v2
id: setup-haskell
with:
ghc-version: 9.10.1
ghc-version: 9.12.1
cabal-version: 'latest'
- name: Install build tools (macOS)
run: brew install automake
Expand Down
12 changes: 2 additions & 10 deletions ghc-lib-gen/src/Ghclibgen.hs
Original file line number Diff line number Diff line change
Expand Up @@ -1567,20 +1567,12 @@ generatePrerequisites ghcFlavor = do
=<< readFile' "./mk/get-win32-tarballs.sh"
)

-- When there is a new GHC release it takes time for package bounds
-- to get updated.
#if __GLASGOW_HASKELL__ == 912
let hadrianExtraCabalFlags = "--allow-newer "
#else
let hadrianExtraCabalFlags = ""
#endif

system_ "bash -c ./boot"
system_ "bash -c \"./configure --enable-tarballs-autodownload\""
withCurrentDirectory "hadrian" $ do
system_ $ "cabal build " ++ hadrianExtraCabalFlags ++ "exe:hadrian --ghc-options=-j"
system_ $ "cabal build exe:hadrian --ghc-options=-j"

Check warning on line 1573 in ghc-lib-gen/src/Ghclibgen.hs

View workflow job for this annotation

GitHub Actions / hlint

Suggestion in generatePrerequisites in module Ghclibgen: Redundant $ ▫︎ Found: "system_ $ \"cabal build exe:hadrian --ghc-options=-j\"" ▫︎ Perhaps: "system_ \"cabal build exe:hadrian --ghc-options=-j\""
system_ . unwords . join $
[ [ "cabal run " ++ hadrianExtraCabalFlags ++ "exe:hadrian --",
[ [ "cabal run exe:hadrian --",
"--directory=..",
"--build-root=ghc-lib"
],
Expand Down

0 comments on commit 080ef42

Please sign in to comment.